Closed Bug 282195 Opened 20 years ago Closed 20 years ago

Click+holding below scroll elevator, then moving cursor down, doesn't result in additional scrolling

Categories

(Core :: XUL, defect)

x86
Windows XP
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: deanis74, Assigned: neil)

References

Details

Attachments

(1 file)

Windows-only bug, spun off from bug 153946. caillon fixed this for OS X and Linux, but I'm still seeing it on Windows. Maybe the NS_MOUSE_MOVE event isn't getting through.
Severity: normal → minor
caillon only fixed it for the case where you move the mouse while scrolling. (And you keep it scrolling you have to keep the mouse over the slider!) Once it stops scrolling it won't restart.
Worse still, mousing over the thumb cancels the repeat too :-(
Attached patch Minimum patchSplinter Review
This is the minimum amount of work to fix the bug. By capturing the mouse we can delay clearing the mChange flag until the mouse is released, thereby allowing us to resume the repeat if the mouse is moved back over the slider. Notes: * Rename the functions because we're not just dragging the thumb? * Make mChange a smaller data type? * Inline HandleRelease?
Assignee: jag → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #174300 - Flags: superreview?(roc)
Attachment #174300 - Flags: review?(roc)
Neil, I think you're actually fixing bug 234300, not this bug.
Aha! That's the bug I was looking for. Dupe that against this one, since we've got a patch here?
Attachment #174300 - Flags: superreview?(roc)
Attachment #174300 - Flags: superreview+
Attachment #174300 - Flags: review?(roc)
Attachment #174300 - Flags: review+
Attachment #174300 - Flags: approval1.8b?
Comment on attachment 174300 [details] [diff] [review] Minimum patch a=asa for checkin to 1.8b
Attachment #174300 - Flags: approval1.8b? → approval1.8b+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 234300 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: