|
2.59 KB,
patch
|
roc
:
review+
roc
:
superreview+
asa
:
approval1.8b+
|
Details | Diff | Splinter Review |
Windows-only bug, spun off from bug 153946. caillon fixed this for OS X and Linux, but I'm still seeing it on Windows. Maybe the NS_MOUSE_MOVE event isn't getting through.
|
(Reporter) | |
Updated•13 years ago
|
||
|
(Assignee) | |
Comment 1•13 years ago
|
||
caillon only fixed it for the case where you move the mouse while scrolling. (And you keep it scrolling you have to keep the mouse over the slider!) Once it stops scrolling it won't restart.
|
|
(Assignee) | |
Comment 2•13 years ago
|
||
Worse still, mousing over the thumb cancels the repeat too :-(
|
|
(Assignee) | |
Comment 3•13 years ago
|
||
Created attachment 174300 [details] [diff] [review] Minimum patch This is the minimum amount of work to fix the bug. By capturing the mouse we can delay clearing the mChange flag until the mouse is released, thereby allowing us to resume the repeat if the mouse is moved back over the slider. Notes: * Rename the functions because we're not just dragging the thumb? * Make mChange a smaller data type? * Inline HandleRelease?
|
||
Comment 4•13 years ago
|
||
Neil, I think you're actually fixing bug 234300, not this bug.
|
|
(Reporter) | |
Comment 5•13 years ago
|
||
Aha! That's the bug I was looking for. Dupe that against this one, since we've got a patch here?
|
|
(Assignee) | |
Updated•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Comment on attachment 174300 [details] [diff] [review] Minimum patch a=asa for checkin to 1.8b
|
|
(Assignee) | |
Comment 7•13 years ago
|
||
Fix checked in.
*** Bug 234300 has been marked as a duplicate of this bug. ***
Description
•