282265 - tree.view not directly available after it is set hidden=false, when it was first hidden=true

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

This issue caused bug 260951.
I'm not sure if it is a bug, feel free to resolve it INVALID, if you think so.

I'll attach a testcase.
When you click for the first time on the "alert(tree.view)" button, it shows 'null'.
But in older builds (before 2004-08-10) it showed '[object XULTreeBuilder]'
already for the first time.

This worked in Firefox build 2004-08-09 06:48am.
But it doesn't work anymore in Firefox build 2004-08-10 06:49am.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-08-09+06%3A48%3A00&maxdate=2004-08-10+06%3A49%3A00&cvsroot=%2Fcvsroot

I think this has changed because of the fix of bug 230170.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.. the patch for bug 260951 looks like a nasty hack that could use backing
out... ;)

I think the right fix is to fix nsBoxObject::GetFrame to flush out frame
construction when it's called.  Now the question is, how often is it called from
inside frame code?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch, should be

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 174334 [details] [diff] [review]
Patch, should be

*cough* this was my master plan all along.... 

Thanks. :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174334 [details] [diff] [review]
Patch, should be

Could this be approved for 1.8b?  This is fallout from back in the summer, and
affects all box object users...  The patch should be pretty safe -- I've
checked our frame code to make sure this function is not called from inside
frame implementations...

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 174334 [details] [diff] [review]
Patch, should be

a=asa for 1.8b

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8b1.

Comment 8

[Bill Gianopoulos [:WG9s]]

Unfortunately, this does not appear to fix the original issue from bug 260951.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Ah, indeed.  The flush is ignored, since we're inside frame construction...  :(

The change in bug 282359 will help with that; if that doesn't land soon, I'll
undo the JS changes in this bug.