260951 - [trunk] Go menu doesn't display recent page history until second opening

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Wayne Woods]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a4) Gecko/20040920 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a4) Gecko/20040920 Firefox/0.9.1+

I've been meaning to report this for some time...
When you start up a Firefox trunk build and click on the Go menu, you don't see
any recently visited web pages, just the Back, Forward, Home and History items.
Close the menu and click on it again, and suddenly the list of pages appears.

This only seems to affect trunk builds from 20040810 (2004-08-10-15) onwards.
The 20040809 (2004-08-09-09) trunk build is fine. The Aviary branch is fine. I
can't reproduce in Seamonkey either.

I can reproduce in the latest nightly, with a fresh profile. I haven't tested it
in Windows yet, only Mac OS X.

Reproducible: Always
Steps to Reproduce:
1.Launch Firefox trunk nightly
2.Click on the Go menu. Observe that no recent pages are displayed.
3.Close the menu and click on Go again. Observe that recent pages are now displayed.




I tried to use Bonsai to determine which patches checked in during that period
might be relevant, but nothing jumped out to my untrained eye. Plus I have no
idea how to make it bring up Firefox-only checkins or trunk-only checkins (is
this even possible?).

Comment 1

[Bill Mason]

I can also see this in Windows 20040919 trunk build.

Comment 2

[Frank Wein [:mcsmurf]]

probably related: Bug 258686

Comment 3

[Ria Klaassen (not reading all bugmail)]

Very annoying bug. You have click a lot to see your Go-list :(

Comment 4

[Ria Klaassen (not reading all bugmail)]

It's a bit strange. When I put the bookmarks-menu into the context-menu, Firefox
shows two bookmarks-menus, one Toolbar-menu and one Context-menu, that's normal
I think, why not.
But when I put the Go-menu into the context-menu, only the Go-list in the
context-menu is working. No matter how many times I click on the
toolbar-Go-menu, it only shows Back - Forward - Home - History, but the list is
gone.
Or maybe this is normal for some reason; I don't know.

Comment 5

[Asaf Romano (gone)]

*** Bug 273307 has been marked as a duplicate of this bug. ***

Comment 6

[Steffen Wilberg]

The js console shows:
Error: history.treeBoxObject.view has no properties
Source File: chrome://browser/content/browser.js
Line: 1228

Comment 7

[Bill Mason]

This bug existed months before the Aviary landing.  It can't be a landing bug.

Comment 8

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a6) Gecko/20041225 Firefox/1.0+
(daihard: P4/SSE2)

Confirmed.

Error: history.treeBoxObject.view has no properties
Source File: chrome://browser/content/browser.js
Line: 1216

Error occurs in this function:

function updateGoMenu(goMenu)
{
  // In case the timer didn't fire.
  destroyGoMenuItems(goMenu);

  var history = document.getElementById("hiddenHistoryTree");
  
  if (history.hidden) {
    history.hidden = false;
    var globalHistory = Components.classes["@mozilla.org/browser/global-history;2"]
                                 
.getService(Components.interfaces.nsIRDFDataSource);
    history.database.AddDataSource(globalHistory);
  }

  if (!history.ref)
    history.ref = "NC:HistoryRoot";
  
  var count = history.treeBoxObject.view.rowCount;
  if (count > 10)
    count = 10;

<snip rest=rest>

Comment 9

[Mike Connor [:mconnor]]

Attachment: patch

I hate trees, la la la-la

Comment 10

[Mike Connor [:mconnor]]

Checking in mozilla/browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.377; previous revision: 1.376
done

Comment 11

[Asaf Romano (gone)]

well, this one was ugly ; )

Comment 12

[Boris Zbarsky [:bzbarsky]]

Note: the patch for bug 282265 will basically back this change out...

Comment 13

[Grayson Mixon (ColdFusion650)]

removing 282359 as a bug this depends on because its resolved.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Er... You do NOT remove dependencies just because the dependent bug is resolved!
 In fact, this bug was also fixed by the patch in bug 282359.  Please do not
ever touch the dependency list of a bug again unless you know what you're doing.