Closed
Bug 282937
Opened 21 years ago
Closed 20 years ago
unused variables in XFormsFunctionCall::evaluate()
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
People
(Reporter: jon, Assigned: jon)
References
()
Details
Attachments
(1 file)
|
6.01 KB,
patch
|
aaronr
:
review+
|
Details | Diff | Splinter Review |
Comment on attachment 174879 [details] [diff] [review]
fix
Good catches. Thanks!
a re-occurring nit:
+ rv = evaluateToNodeSet((Expr*)iter.next(), aContext,
getter_AddRefs(nodes));
Since you are removing the nsresult rv declaration in lots of these cases
(which is great), make sure that the parameters still line up nicely or move
the getter_AddRefs up on the same line if there is room.
With that, r=me
Attachment #174879 -
Flags: review?(aaronr) → review+
Argh. (Attachment 174788 [details] [diff].)
*** This bug has been marked as a duplicate of 90906 ***
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•