28398 - Gotta be more careful when emailing state changes of dependent bugs.

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P2)

Description

[Terry Weissman]

The below entertaining mail was generated.  I think what is happening (haven't
looked at the code yet) is when bug B is changed to be dependent on bug A, then
you get notified of all changes to bug A's state that happened ever since you
last generated email diffs for bug *B*.  This is not particularly useful.

Date: Thu, 17 Feb 2000 17:47:16 -0800 (PST)
From: [e-mail]
To: [e-mail]
Subject: [Bug 24890] Changed - Cannot dismiss sub-dialogs brought up from prefs
panel

	(text/plain)
http://bugzilla.mozilla.org/show_bug.cgi?id=24890

[e-mail] changed:

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |28083,28177

This bug depends on bug 28177, which changed state:

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |
             Status|REOPENED                    |NEW
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From [e-mail]  2000-02-17 17:47 -------
verif blocked by bugs 28177 and 28083.

Comment 1

[Matthew Tuck [:CodeMachine]]

I've seen this issue too, Terry, though not to that extent.

Wrong bug to comment on I think, sairuh.

Comment 2

[sairuh (rarely reading bugmail)]

whups... i did that a while ago, too. um, pls disregard my 2000-02-17 comment.
(esp since those bugs involved are now verified fixed. :-)

Comment 3

[Matthew Tuck [:CodeMachine]]

Sorry sairuh I just realised that you comment was actually pasted from the
notification above by Terry!

Terry, is there anything we can do to prevent this?  It looks like you can spoof
people's comments.  One thing that comes to mind is by making the real headers
bold (they're logically separated in the database now I believe?)

I didn't realise there was auto-hyperlinkifying, I presume that's what happened
here to get the links in your comment.

Comment 4

[Stuart Parmenter]

sairuh is tricky.  you gotta watch out for her. ;-)

Comment 5

[Terry Weissman]

Yes, bold-facing (or italicizing or something) the headers of the comments is
something I keep meaning to do one of these days.

And yes, anything that looks like a URL (for example,
http://bugzilla.mozilla.org) does automatically become a hyperlink when the bug
is displayed.

Comment 6

[Terry Weissman]

OK, for the record, I just put in the italicizing stuff mentioned above.

Comment 7

[sairuh (rarely reading bugmail)]

coolness!

Comment 8

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 9

[Chris Yeh]

if the italics are in, is this fixed?

Comment 10

[Matthew Tuck [:CodeMachine]]

This bug is not about italics, cyeh, we just were naughty in discussing it here.

Comment 11

[Dave Miller [:justdave]]

moving to real milestones...

Comment 12

[Matthew Tuck [:CodeMachine]]

*** Bug 96157 has been marked as a duplicate of this bug. ***

Comment 13

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 14

[Bradley Baetz (:bbaetz)]

This just happened to me. The problem is where we look for status changes:

"... AND bug_when > '$start' AND bug_when <= '$end' "

Because of the order in which we process stuff, this will only affect bugs where
we change bug x to mark it as depending on bug y, and bug y has status changes.

However, I have no idea how to fix it...

Comment 15

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 16

[Dave Miller [:justdave]]

Changing default owner of Email Notifications component to JayPee, a.k.a.
J. Paul Reed ([e-mail]).  Jake will be offline for a few months.

Comment 17

[Joel Peshkin]

--> 2.20 since this certainly wont make 2.18

Comment 18

[Max Kanat-Alexander]

As preed is no longer actively working on Bugzilla (from what I know), I somehow
doubt that this bug will make it in for 2.20. :-) If I'm wrong, feel free to
take it back and re-target it. :-)

Comment 19

[Dave Miller [:justdave]]

*** Bug 285041 has been marked as a duplicate of this bug. ***

Comment 20

[Frédéric Buclin]

*** Bug 309544 has been marked as a duplicate of this bug. ***

Comment 21

[André Batosti]

Attachment: batosti_v1

Comment 22

[Frédéric Buclin]

reading this bug description again, it looks like bug 309544 is not a dupe of
this one... and then this patch should not be here. :) But this bug summary is
confusing.

Comment 23

[Frédéric Buclin]

Comment on attachment 197029 [details] [diff] [review]
batosti_v1

>Index: template/en/default/bug/process/bugmail.html.tmpl

>+  [% IF can_see_bug %]

You can use [% IF user.can_see_bug(mailing_bugid) %] directly, without passing
it as a param.

Comment 24

[André Batosti]

Attachment: batosti_v1_fix: user.can_see_bug() on template.

Comment 25

[Frédéric Buclin]

Comment on attachment 198693 [details] [diff] [review]
batosti_v1_fix: user.can_see_bug() on template.

>Index: template/en/default/bug/process/bugmail.html.tmpl

>+    (list of e-mails not avaliable)

Nit: available


This can be fixed on checkin. r=LpSolit

Comment 26

[Joel Peshkin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.286; previous revision: 1.285
done
Checking in template/en/default/bug/process/bugmail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/bugmail.html.tmpl,v
 <--  bugmail.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Comment 27

[Frédéric Buclin]

The "fix on checkin" was missing!

Checking in template/en/default/bug/process/bugmail.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/bugmail.html.tmpl,v
 <--  bugmail.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Comment 28

[Frédéric Buclin]

*** Bug 148786 has been marked as a duplicate of this bug. ***

Comment 29

[Dave Miller [:justdave]]

This fix either didn't work or regressed (more likely it didn't work, which is why I'm reopening this instead of filing a new bug).  This is still present as of 3.0.3.

Subject: [Bug 322568] PalmSyncInstall has not been built since October [SM suite]
Date: Wed, 28 May 2008 09:13:50 -0700
From: [e-mail]
To: [e-mail]
References: <[e-mail]/>

Do not reply to this email.  You can add comments to this bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=322568


Bug 322568 depends on bug 392438, which changed state.

Bug 392438 Summary: upgrade community Windows machines to the new ref platform
https://bugzilla.mozilla.org/show_bug.cgi?id=392438

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |NEW
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |NEW
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |NEW
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED 

Comment 30

[Dave Miller [:justdave]]

Re-reviewing what was discussed on the bug here, I'm almost positive this was never fixed.  The patch that was committed doesn't appear to have anything to do with this problem?

Comment 31

[Reed Loden [:reed]]

(In reply to comment #29)
> This fix either didn't work or regressed (more likely it didn't work, which is
> why I'm reopening this instead of filing a new bug).  This is still present as
> of 3.0.3.

I filed bug 396558 on this already...

Comment 32

[Frédéric Buclin]

Let's keep this bug as FIXED. Fix bug 396558 instead.