285121 - Only run "old" table checks if the database is MySQL

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement, P1)

Description

[Max Kanat-Alexander]

In an effort to speed up cross-database installation support, and actually get
it complete in the time that we have, I think that we should wrap ALL the
current table changes in a block that only runs if the database is MySQL, and
then only table changes that come after 2.20 will have to worry about being
Pg-compatible.

This means that until we actually implement bz-dbinstall (that's a bug alias),
PostgreSQL users should be not expect to be able to upgrade smoothly without
some manual code-running.

Comment 1

[Max Kanat-Alexander]

Attachment: Wrap Upgrade Code in MySQL-specific wrapper

Comment 2

[:glob ✱]

Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

r=glob

not a big fan of the lack of indentation, but we're already do that in
checksetup (BEGIN block).

r+ in its current form.  bonus points if you display a warning to non-mysql
users.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

Actually, this causes some minor problems on Pg.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

Nevermind, this one is OK.

Comment 5

[Max Kanat-Alexander]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.370; previous revision: 1.369
done