Only run "old" table checks if the database is MySQL

RESOLVED FIXED in Bugzilla 2.20

Status

()

enhancement
P1
normal
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

2.19.2
Bugzilla 2.20
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment)

In an effort to speed up cross-database installation support, and actually get
it complete in the time that we have, I think that we should wrap ALL the
current table changes in a block that only runs if the database is MySQL, and
then only table changes that come after 2.20 will have to worry about being
Pg-compatible.

This means that until we actually implement bz-dbinstall (that's a bug alias),
PostgreSQL users should be not expect to be able to upgrade smoothly without
some manual code-running.
Status: NEW → ASSIGNED
Depends on: 280856
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Attachment #176839 - Flags: review?(bugzilla)
Blocks: 285401
Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

r=glob

not a big fan of the lack of indentation, but we're already do that in
checksetup (BEGIN block).

r+ in its current form.  bonus points if you display a warning to non-mysql
users.
Attachment #176839 - Flags: review?(bugzilla) → review+
Flags: approval?
Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

Actually, this causes some minor problems on Pg.
Attachment #176839 - Attachment is obsolete: true
Comment on attachment 176839 [details] [diff] [review]
Wrap Upgrade Code in MySQL-specific wrapper

Nevermind, this one is OK.
Attachment #176839 - Attachment is obsolete: false
Flags: approval? → approval+
No longer blocks: 285401
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.370; previous revision: 1.369
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.