Closed Bug 285182 Opened 19 years ago Closed 9 days ago

Command-double-click bookmark in Bookmarks has wierd/inconsistent behaviors

Categories

(Camino Graveyard :: Bookmarks, defect, P2)

PowerPC
macOS

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: markturner, Unassigned)

References

Details

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.2; Mac_PowerPC)
Build Identifier: 2005030608 (v0.8+)

In the bookmark manager, if you command-double click a bookmark, nothing
happens. However if you higlight a bookmark and then choose "open in new tab"
from the action button menu, subsequent bookmarks are opened in new tabs when
command-double clicked. But then there still remains the problem that if a
bookmark already is highlighted, that is the one that is opened and not the one
you actually clicked on.

Reproducible: Always

Steps to Reproduce:
1.Open new window
I can confirm this issue as described on a custom build from 10 March.
Was this always this way, or did it regress at some point?
I don't think this behaviour is wrong, because command + click is used to make
non-contiguos selection, when in list-mode (as is the bookmark manager). A
command-double-click should (in my opinion) do nothing, because the first click
selccts a bookmark and the second deselects it.
If I command-double-click an item in a Finder window list view, though, the item
opens.  If I've already selected two items and I command-double-click on the
third item, all the three open.  So I think Camino is in the wrong here.

To answer Simon's question, I checked "release" builds as far back as 0.8b and
it didn't work in any of them.  I don't know when after 0.7 the new BM landed,
but I'm guessing this never worked.

Based on the Finder behavior, I'm confirming this bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Command-click ios used to create a discontiguous selection. So are we talking
about command-double-click?
Summary: command-click bookmark only opens new tab if you previously used "open in new tab" → Command-double-click bookmark in Bookmarks only opens new tab if you previously used "open in new tab"
(In reply to comment #6)
> Command-click ios used to create a discontiguous selection. So are we talking
> about command-double-click?

Yes, I believe so, based on the original description.
Just to make clear to everyody what I mean: Check out Safari, it ehaves exactly
like I think Camino should be behaving, too. This would be a huge improvement,
since it allows you to open a number of bookmarks with only opening the
bm-manger once. I would go so far to call it one of the most basic features a
browser should have if has tabs.
As others mentioned, I think one of the problems could be that Camino needs to
distinguish between two command-clicks (selection/deselection) and a
command-double-click.

I don't know if that is related or not, so I'm not filing a new bug just yet,
but you should also be able to select more than one bookmark and open all of
them in tabs using the action button at the bottom of the page (the drop down
item should then probably be called "open in new tab(s)"). This currently works
only if only one bookmark is selected.
Camino has a really buggy behaviour here.

No selection: Command double-click does nothing
Bookmarks selected: Command double-click _anywhere in the bookmarks manager_
opens the first one in a new tab

Totally unexpected behaviour; you have an unrelated bookmark selected, and
cmd-double-click a bookmark to open it in a new tab. Result: the originally
selected bookmark opens in a new tab.
Yeah, it's pretty busted in history too.
Assignee: pinkerton → sfraser_bugs
The problem here is that the Command key is used to make a discontinguous
selection in the outliner, so we need to be careful with the click handling.
Status: NEW → ASSIGNED
I don't think that's a big problem. Remember, we're talking about
command-*double*clicks. Camino just needs to know the difference between two
single clicks and a double-click. Everytime you open a document your OS has to
do the exact same thing. It has proven to work quite well. :D
(In reply to comment #12)
> I don't think that's a big problem. Remember, we're talking about
> command-*double*clicks. Camino just needs to know the difference between two
> single clicks and a double-click. Everytime you open a document your OS has to
> do the exact same thing. It has proven to work quite well. :D

It's a problem because the click handling code is buried inside Cocoa.
I added the ability to open multiple bookmark or history items by fixing the
control-click behavior to not deselect other items first. Command-double-click
is still weird, because the double click deselects and then selects again the
item under the mouse, but it will open the items in tabs.
Priority: -- → P2
Target Milestone: --- → Camino1.0
Ooops.
Severity: normal → minor
Target Milestone: Camino1.0 → Camino1.2
*** Bug 315573 has been marked as a duplicate of this bug. ***
Summary: Command-double-click bookmark in Bookmarks only opens new tab if you previously used "open in new tab" → Command-double-click bookmark in Bookmarks has wierd/inconsistent behaviors
Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.
Target Milestone: Camino1.6 → ---
Assignee: sfraser_bugs → nobody
Status: ASSIGNED → NEW
QA Contact: bookmarks
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.