Closed
Bug 285325
Opened 19 years ago
Closed 15 years ago
Use css for smileys in mail_help.xhtml
Categories
(SeaMonkey :: Help Documentation, defect)
SeaMonkey
Help Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0b1
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file, 3 obsolete files)
9.17 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
By using the css in communicator/skin/smileys.css we can get rid of 4 images in Help.
Assignee | ||
Comment 1•19 years ago
|
||
This will make the 4 smiley-images in /images obsolete, so they can be removed. I had to add some style to the spans in order to avoid the top/bottom of the smileys to be cut off at small font-sizes (default on mac, unfortunately). Ian, I saved the css overhaul for another bug ;)
Attachment #176763 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•19 years ago
|
||
Actually, padding-top and padding-bottom might be a bit more accurate, since that is actually what we want here.
Attachment #176763 -
Attachment is obsolete: true
Attachment #176774 -
Flags: review?(bugzilla)
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 176763 [details] [diff] [review] Use css for smiley images Terribly sorry for all the bugspam...
Attachment #176763 -
Flags: review?(bugzilla)
Comment 4•19 years ago
|
||
You shouldn't have to add padding, smileys.css should handle everything. If it doesn't then it will affect mail anyway :-P
Assignee | ||
Comment 5•19 years ago
|
||
(In reply to comment #4) > You shouldn't have to add padding, smileys.css should handle everything. > If it doesn't then it will affect mail anyway :-P It does affects mail. On mac, the smileys are cut-off at the top and bottom using default font-size. I can try to fix that first in a separate bug if you want.
Comment 6•19 years ago
|
||
Actually I think it might have already been filed, but I would rather see it fixed globally instead of having a help-specific hack.
Assignee | ||
Comment 7•19 years ago
|
||
(In reply to comment #6) > Actually I think it might have already been filed, but I would rather see it > fixed globally instead of having a help-specific hack. Hmm, for the moment I can only think of two ways to fix that: 1) Add padding-top and padding-bottom If you add, for instance, 10px top and bottom padding the smiley will never be cut-off. The downside is that it will overlap the text if you make the text smaller. 2) Use a larger font-size (18-19) to fix the issue in mac default (100% text zoom) Smileys will be cut off at text zoom < 100% and gap between lines (that has a smiley) will be wider than it is now.
Assignee | ||
Comment 8•19 years ago
|
||
Here's one attempt to fix the underlaying problem: Using :after. One issue might be that the smileys are not 100% vertically centered, despite the usage of vertical-align: center. Comments are welcome.
Attachment #176774 -
Attachment is obsolete: true
Assignee | ||
Updated•19 years ago
|
Attachment #176774 -
Flags: review?(bugzilla)
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 178936 [details] [diff] [review] one attempt to fix the problem globally Just note that I forgot to change one entry in the css file...
Assignee | ||
Comment 10•19 years ago
|
||
Comment on attachment 178936 [details] [diff] [review] one attempt to fix the problem globally Hmm, this doesn't work. You can't remove an added smiley when you compose a message in html format :(
Attachment #178936 -
Attachment is obsolete: true
Assignee | ||
Comment 11•19 years ago
|
||
We've been talking about getting new smileys for the two themes. If we had smaller icons we could avoid the problem of smileys being cut-off at 100% and 90% text zoom in MailNews...
Comment 12•19 years ago
|
||
Maybe we could fix it using XBL?
Assignee | ||
Comment 13•19 years ago
|
||
(In reply to comment #12) > Maybe we could fix it using XBL? You mean fixing the Help stuff or the global issue?
Assignee | ||
Updated•17 years ago
|
Component: Help Viewer → Help
Product: Documentation → Mozilla Application Suite
Version: unspecified → Trunk
Assignee | ||
Comment 14•15 years ago
|
||
I think it's time to fix this now... ;-) Maybe they're not perfectly (vertically) aligned, but I didn't tried replacing the old images and the existing ones are not really centered either.
Attachment #373193 -
Flags: review?(iann_bugzilla)
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0b1
Assignee | ||
Comment 15•15 years ago
|
||
(In reply to comment #14) > and the > existing ones are not really centered either. "And the old images are not..."
Comment 16•15 years ago
|
||
Comment on attachment 373193 [details] [diff] [review] Updated patch Looks good change from 21x21 to 16x16 does not seem to have broken anything from what I can see.
Attachment #373193 -
Flags: review?(iann_bugzilla) → review+
Assignee | ||
Comment 17•15 years ago
|
||
http://hg.mozilla.org/comm-central/rev/b32c39c77951
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•