286008 - Unable to create new users (createaccount.cgi)

Status: RESOLVED WORKSFORME

(Bugzilla :: Email Notifications, defect)

Description

[Gervase Markham [:gerv]]

The checkin for bug 277623 broke createaccount.cgi:

"Software error:

Undefined subroutine &main::PerformSubsts called at CGI.pl line 199."

Patch coming up.

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This fixes the reported problem, although someone should probably check all
other non-BugMail.pm calls to PerformSubsts() to make sure they work too.

Gerv

Comment 2

[Frédéric Buclin]

As MailPassword() is only called from createaccount.cgi, a better fix would be
to move this function in BugMail.pm in the process of removing subs from CGI.pl.

I'm sure mkanat would appreciate! ;)

Comment 3

[Gervase Markham [:gerv]]

We should do the minimum fix to unbreak the tree, and handle any enhancements
separately, IMO.

Gerv

Comment 4

[Gervase Markham [:gerv]]

This seems to have been fixed by some other change.

Gerv

Comment 5

[Frédéric Buclin]

Comment on attachment 177322 [details] [diff] [review]
Patch v.1

PerformSubsts() has always been in the EXPORT section since mkanat moved it
into BugMail.pm, so adding Bugzilla::BugMail does not help. By the way, I
cannot reproduce this problem.

Comment 6

[Dave Miller [:justdave]]

clearing target of DUPLICATE/WONTFIX/INVALID/WORKSFORME so they'll show up as
untriaged if they get reopened.