286287 - tab switching accel overlaps with access keys on web pages

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Sabin Iacob]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050309 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050309 Firefox/1.0.1

The combination used to switch tabs (alt+number) overlaps with numeric access
keys on web pages (for a breadcrumb navigation for example). I think this
behavior is due to a typo (the function in browser.js is called
ctrlNumberTabSelection, but it actually acts on the alt key).

Reproducible: Always

Steps to Reproduce:
1.create several tabs
2.press alt+[1-8]


Actual Results:  
the tabs should change (alt+1 for the first, alt+2 for the second, and so on)

Expected Results:  
nothing

Comment 1

[Sabin Iacob]

Attachment: patch to fix browser.js

here is a patch to fix it (you need to extract chrome/browser.jar first, patch
browser.js, then repack the whole thing)

Comment 2

[Nickolay_Ponomarev]

Looks like it's intended behavior:

http://lxr.mozilla.org/seamonkey/source/browser/base/content/browser.js#1215
1215 #ifdef XP_MACOSX
1216   if (!event.metaKey)
1217 #else
1218 #ifdef XP_UNIX
1219   if (!event.altKey)
1220 #else
1221   if (!event.ctrlKey)
1222 #endif
1223 #endif

Comment 3

[Max Lindner]

nobody cares about this?

Comment 4

[Ed Lee :Mardak]

This seems to be a duplicate of bug 264204 (or bug 128452?) which was partially
caused by fixing bug 256635.

Comment 5

[Jackie Liu]

WFM "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20060926 BonEcho/2.0"

Comment 6

[Kevin Brosnan]

Using the alt key + # is the expected behavior on Linux see bug 256635. As an aside the accessibility key modifier for Firefox 2 is alt + shift plus what the page designer set.