28670 - No scrollbars after leaving frameset page

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[Alec Flett]

Go to http://devedge.netscape.com/
Click on the "Documentation" link in the left column. (Also works with many of
the other toplevel pages)

Notice that there are no scrollbars in the content that appears, so you can't
get to anything below the bottom of the window.

This is on Linux, don't know about windows.

Comment 1

[Alec Flett]

nominate for beta1, add URL

Comment 2

[leger]

Putting on PDT+ radar for beta1.

Comment 3

[Peter Trudelle]

reproduced in today's NS verification build on Win98

Comment 4

[leger]

Must fix by 03/10.

Comment 5

[Eli Goldberg]

This occurs reproducibly on tons of other frames-based pages, especially news.com.

Or, see this week's www.theonion.com, and click on the "Senate Candidate Drops
Out Of Race Due To Shyness" link.

Comment 6

[Eli Goldberg]

<Generalized subject to reflect broader significance of bug.>

Comment 7

[Eric Vaughan]

This began happening just after Eric P's change to nsHTMLContentSink on the 
19th. I believe its the modifications to the scrolling behavior.

Comment 8

[Eli Goldberg]

[added to M14 release notes scratchpad.]

Comment 9

[Eric Pollmann]

The scrollbars problem is when going from a frameset page to a non-frameset
page.

Page Up/Dn not working is a separate, unrelated bug.  Updating Summary.

Comment 10

[Eric Pollmann]

Fixing typo.  :)

Comment 11

[Eric Pollmann]

The problem is that nsWebShell::InitFrameData is not called on every page view
as I thought it was when I came up with the fix for bug 14827.

It seems I will have to go with the alternate fix I came up with:

Split InitFrameData into two methods (it really is)
 1) InitFrameData() a private method that initializes scrolling and margins
 2) ResetScrolling() a public method that resets scrolling state to the default

In places where InitFrameData(PR_FALSE) is called, these calls will be replaced
with ResetScrolling().

A call to ResetScrolling() will be added to HTMLContentSink::StartLayout() for
non-frameset documents.

I have these changes in my tree ready for testing, will update status when done.

Comment 12

[travis]

Where are you making these changes?  Please come talk to me before making any 
additions to nsIWebShell.

Comment 13

[Eric Pollmann]

After talking with Travis, I will be using a different fix:

Get/SetScrollbarProperties on nsIScrollable interface of nsDocShell

I will be implementing these methods and replacing all current usage of
Get/SetScrolling on nsIWebShell with these.  I will probably also need to
implement ResetScrollbarProperties on nsIScrollable until nsScrollPortFrame
implements handle SetScrollProp.  This will be well documented in my change with
XXX's.

Comment 14

[Eric Pollmann]

This fix is mostly done as of now, but I am currently having a problem with XUL
documents getting extra scrollbars in edge cases that I'm tracking down.

Comment 15

[Eric Pollmann]

(Restoring status whiteboard comment, oops!  :)

Also, as an update on the new fix, I expect to have this fix in hand today but I
will not be able to check in until thoroughly tested, reviewed, and approved. 
Estimating 2/28.

Comment 16

[Eric Pollmann]

I have a reviewed fix in hand, need approval.

Comment 17

[Peter Trudelle]

*** Bug 29471 has been marked as a duplicate of this bug. ***

Comment 18

[Eric Pollmann]

Fix checked in!

To verify:

1) Go to developer.netscape.com  Click on a link in the left column.  The page
you see should have scrollbars so that you can see the bottom portion

2) Go to news.com  Click on a link anywhere in the page.  The page you see
should have scrollbars so that you can scroll down and see the bottom.

Comment 19

[Chris Petersen]

Marking verified fixed in the March 09 (2000030914).

Comment 20

[Matthias Versen [:Matti]]

mid-air collision ? / bugzilla cleanup
Reopening (current State: verfied and no resolution)

Comment 21

[Matthias Versen [:Matti]]

fixed

Comment 22

[Matthias Versen [:Matti]]

verfied