28676 - When a bug is marked duplicate, the reporter should be added to the bug that it duplicated.

Status: VERIFIED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Kevin Berkheiser]

What I mean is the when a bug is marked duplicate, the reporter of that bug and 
perhaps even its cc list should be added to the bug that the reports bug was a 
duplicate of.

Comment 1

[Matthew Tuck [:CodeMachine]]

This should not be done immediately due to the chance of reopening, although it
is not a tragedy if it is.  I suggest about a week after.

Comment 2

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 3

[Dave Miller [:justdave]]

They might miss some important details if you wait to do it though, Matt.  If I 
were the reporter whose bug was marked a duplicate, I'd like to get added to the 
original bug immediately.  As you said it's not a tragedy...  if it turned out to 
be an error, I can reopen my bug and remove my CC from the other one (although if 
it's somewhat related, I probably wouldn't remove the CC anyway).

Comment 4

[Chris Yeh]

this is a good idea.

Comment 5

[Dave Miller [:justdave]]

*** Bug 51232 has been marked as a duplicate of this bug. ***

Comment 6

[Diego]

Added (by hand) in the cc: me and the reporter of the dupe bug that points to
this one :-)

Comment 7

[Gervase Markham [:gerv]]

This should be a pref; I'd hate it. I get notified by email if a bug is resolved 
dupe anyway; if I want to add myself to the CC of the new one, I will :-)

Gerv

Comment 8

[Chris Yeh]

I think dragging in the cclist is overkill, but adding the reporter to the cc of 
the original sounds like a good idea, and not too much of a burden. I haven't 
looked at how much code this involves, so this may drop off the 2.12 train.

Comment 9

[Chris Yeh]

I took a look at how much work it would be to do this, and it's a single sql 
insert into the cc table. It can be done in such a way that it doesn't generate 
another e-mail on the bug that just had it's cc list updated.

Gerv: Can you go into more detail why you hate the idea of automatically adding 
the reporter to a bug? And if you were to do it as a pref, do you see this as 
system wide or per user?

Comment 10

[Dave Miller [:justdave]]

It's not going to make an additional email anyway, it's already sending one on 
duplicates to tell people that the comment about "such and such bug has been 
marked a duplicate of this one", so the CC change will just be an extra line in 
the same email.

Comment 11

[Gervase Markham [:gerv]]

I don't have a problem with "only the reporter", just "entire CC list import." 
Go ahead and check in your single line SQL query :-)

Gerv

Comment 12

[[e-mail]]

An alternative would be to add a link to the duplication notification email 
which the recipient can click to add themself to the CC list of the other bug.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Neil: one problem with that is that any mails between the time of
duplicate-marking and the time of click-through on the received mail get missed
by the recipient.

Comment 14

[[e-mail]]

I always read the duplicated bug anyway (so this isn't a problem for me) by 
which time I can add myself as a CC. Unfortunately I'm to lazy to retype my 
email address so I don't unless I can spare the vote to vote for the bug :-)

Comment 15

[Eric Vaandering (no email)]

I'd like to see some easy way of doing this too. I like to keep track of bugs I
notice, but feel bad adding a CC: and sending a whole list of people mail

Comment 16

[Chris Yeh]

Here's a diff. This works for me.

Index: process_bug.cgi
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v
retrieving revision 1.68
diff -c -r1.68 process_bug.cgi
*** process_bug.cgi     2000/12/14 12:17:11     1.68
--- process_bug.cgi     2000/12/14 23:06:32
***************
*** 543,548 ****
--- 543,551 ----
          if ( Param('strictvaluechecks') ) {
            CheckFormFieldDefined(\%::FORM,'comment');
          }
+         SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($::FORM
{'id'}));
+       my $reporter = FetchOneColumn();
+       SendSQL("INSERT INTO cc VALUES ($reporter, $num)");
          SendSQL("INSERT INTO duplicates VALUES ($num, $::FORM{'id'})");
          $::FORM{'comment'} .= "\n\n*** This bug has been marked as a 
duplicate of $num ***";
          print "<TABLE BORDER=1><TD><H2>Notation added to bug $num</H2>\n";

Comment 17

[[e-mail]]

Chris Yeh wrote:
> SendSQL("INSERT INTO cc VALUES ($reporter, $num)");

What happens if the reporter is already a CC of the duplicate?

Comment 18

[Dave Miller [:justdave]]

If the reporter is already a CC, that SQL will fail because the cc/who combo is 
declared as unique in the table declaration.  However, when an SendSQL call 
fails, it dumps the error to the browser instead of returning...  so that isn't a 
real good idea.  Need to check if it's there already first...

Comment 19

[Jacob Steenhagen]

There should also be some text to the reporter that specifically tells them that
they have been added to the CC list of the "original" bug.  I don't think it's
good enough to expect them to decipher the CC field change. (Unless bug 61015 is
implimented).

Comment 20

[Andreas Franke (gone)]

I think there should be a user-pref for auto-migrating from one cc-list to the
other. Those users who add themselves to the new bug anyway most of the time
would turn it on because it's less work for them and fewer mails for everybody
if they remove themselves from the few bugs they aren't interested in. 
And people like Gerv could turn it off.

Comment 21

[Jacob Steenhagen]

Taking bug to make a patch.

The basic process-flow will be:
 * Check if reporter of this bug is on CC of dupe or reporter of dupe
 * If not, Add them to the CC of dupe

Short, sweet, and strait to the point.  Should have it done shortly.

Comment 22

[Jacob Steenhagen]

Attachment: patch - add reporter to cc

Comment 23

[Jacob Steenhagen]

OK... here it is and in working order.  This patch does what I said it would
with one addition... it also records the action in bugs_activity (so it will
show up in the e-mail and on the show_activity.cgi page).

Comment 24

[Stephan Niemz]

I have tested this patch on my local Bugzilla installation and it works
as advertised. r=me, for what it's worth.

Comment 25

[Chris Yeh]

Okay, I've reviewed the patch and tested it, and I agree that it works and looks 
fine. I don't know if jake has checkin access. If not, I can check it in.

Comment 26

[Chris Yeh]

patch has been committed to the trunk.

Comment 27

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 28

[Gervase Markham [:gerv]]

VERIFIED.

Gerv

Comment 29

[Jacob Steenhagen]

*** Bug 61246 has been marked as a duplicate of this bug. ***

Comment 30

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product