28756 - [IMAP] need to use shared folder icons.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

in 4.x, if an imap folder was shared, it would use a special icon in the folder
pane.

these icons are checked in:

mozilla/mailnews/base/resources/skin/folder-share-open.gif and
mozilla/mailnews/base/resources/skin/folder-share.gif

now all we need to do is reflect the "shared" property in the folder datasource
and in the CSS rules to make them show up in the 5.0 ui.

Comment 1

[(not reading, please use [e-mail] instead)]

moving to m16.  this is polish.

Comment 2

[David :Bienvenu]

jeff has already done NoSelect - this seems to fit with that.

Comment 3

[selmer (gone)]

Not beta2 stopper, marking M18.  Please add beta2 keyword if you disagree.

Comment 4

[scottputterman]

reassigning jefft's bugs to naving

Comment 5

[scottputterman]

reassigning to bienvenu.

Comment 6

[Karen Huang]

*** Bug 41363 has been marked as a duplicate of this bug. ***

Comment 7

[David :Bienvenu]

cc'ing Navin for code reviews for upcoming patches.

Comment 8

[David :Bienvenu]

Attachment: proposed fix

show shared folder icon for non-special folders (not sure if we want to do
inbox,sent, etc...since it will add a bunch more css fules) I didn't do the
open folder icons since we're not distinguishing between open and closed
folders that I can see in our skins.

Comment 9

[David :Bienvenu]

Attachment: imap part of diffs

hook up call into libmsg backend to set shared flag on folder if the imap code
decides the front end needs to get redisplayed.

Comment 10

[David :Bienvenu]

Attachment: base part of proposed fix

all the grief you have to go through to reflect imapshared property through
rdf.

Comment 11

[Navin Gupta]

Comment on attachment 69124 [details] [diff] [review]
imap part of diffs

r=naving

Comment 12

[Navin Gupta]

why are you adding imap-shared attribute to base? shouldn't it be on imapFolder

Comment 13

[David :Bienvenu]

the code could just as easily be in base as in imap (it's checking a flag that's
defined throughout the whole code base - the flag is just never set for a
non-imap folder, currently). I could have defined two methods, one in base, that
always returned false, and one in imap that checked the folder flag. But I chose
to just have one method defined instead of two to save on overall code space.

Comment 14

[Navin Gupta]

Can you add a comment about the imapShared attribute?

your changes in nsMsgDBFolder don't look related to this bug. Commiting db
for shared folder icons !!!

Comment 15

[Navin Gupta]

r=naving on base diffs once you address the above comment

Comment 16

[David :Bienvenu]

yes, you're right, the nsMsgDBFolder changes aren't part of this bug - I won't
check them in. I'll add a comment to the idl file about the imapShared attribute.

Comment 17

[David :Bienvenu]

we do actually store the shared folder flag in the db, which we use to display
the shared folder icon, so committing the db could be involved :-)

Comment 18

[Navin Gupta]

No, that db commit is on switching folder and already we are committing
just above (if diffs are correct)

Comment 19

[David :Bienvenu]

no, I'm just pointing out that it's not completely silly that commiting the db
might be involved with shared folder icons.

Comment 20

[David :Bienvenu]

this is fixed for the case where the user selects the shared folder - after
that, we know it's shared. I'm not sure if we know it on folder discovery for a
new account, but I'm not sure if 4.x worked for that either. I'll check into it,
but this works once you select the shared folder, and forever after that.

Comment 21

[scottputterman]

moving to 1.0

Comment 22

[David :Bienvenu]

seems to work for newly discovered folders too. marking fixed.

Comment 23

[Karen Huang]

Used 03-19-09-trunk build
Reopening this bug since I don't see the special icons displaying for IMAP 
shared Folders.....

Comment 24

[Karen Huang]

Oops! I used 03-18-09-trunk build....

Comment 25

[Karen Huang]

Attachment: screen shot of without the shared folder icons displaying.....

Comment 26

[Karen Huang]

Attachment: screen shot of without the shared folder icons displaying.....

Comment 27

[Karen Huang]

Attachment: attach 4.7x screen shot of the IMAP Shared folders

Comment 28

[David :Bienvenu]

Karen, the screen shots you attached ARE showing the shared folder icon - it's
just different in 6.x than 4.x

Comment 29

[Karen Huang]

Hmm...interesting. After I created new profile for today's 03-22-05-trunk build.
I got the 6.x shared folders' icons which are similar to 4.x...
David, have you changed these icons on 6.x?

Comment 30

[Karen Huang]

Attachment: attach today's 6.x 03-22-05-trunk build IMAP shared Folders' icons

Comment 31

[David :Bienvenu]

Karen, I don't do icons :-) but looking at your screen shots, I would say your
most recent screen shot is in the classic skin, and your previous screen shot is
in the modern skin, so it makes sense they would look different.

Comment 32

[Karen Huang]

Thanks David point this out.
Yes, today's build default is "classic", and based on the UI Spec as following:

http://www.mozilla.org/mailnews/specs/folder/#Sharing

I logged other two bugs (bug 132927 & bug 132932) for tracking the rest IMAP 
Shared folder icons for IMAP default/special shared folders and OPEN shared 
Folders.

Marking as verified for this bug.

Comment 33

[Karen Huang]

I just notice that the IMAP Shared Folders icons did display for PERSONAL Shared 
Folder, but are not displaying for OTHER USER'S Shared Folders.....bug 142258 
logged.
I am wondering to know whether I should reopen 
this bug for not fixing completely or somebody should look at bug 142258....
I know it's a little bit late for finding this problem.... (I have focused on 
IMAP Shared Folders functionality and thought this bug had been fixed 
completely....)
Whoever do the icons, can you confirm whether it's too late for RTM as David 
described in bug 142258?

Also, Jennifer, can you add and update this in your UI Spec since IMAP Shared 
Folders icons should display on both PERSONAL and OTHER USER'S Shared 
Folders which is describing very clear in the UI Spec, Thanks.
http://www.mozilla.org/mailnews/specs/folder/#Sharing

Comment 34

[Karen Huang]

Jennifer, can you add and update this in your UI Spec?.......I mean sinc it is 
NOT describing very clear in the UI Spec, Thanks.
http://www.mozilla.org/mailnews/specs/folder/#Sharing

Comment 35

[David :Bienvenu]

Karen, I mean it's too late to change the code to make other users' folders show
this icon. We already have the icon. I mean the ADT would not accept this kind
of cosmetic change at this point in the release cycle.

Comment 36

[jglick]

Karen, the icons that should be used in the folder pane when folders are shared, 
both Personal and Special folders, both Modern and Classic, are shown here: 
http://www.mozilla.org/mailnews/specs/folder/images/ShareIcons.gif

The icons should already exist. Marlon Bishop is the guy to see to get a hold of 
 the files as nec.