287637 - Opening link in new tab with Java applet applies that tab's URL, security icon, etc to all tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Jason Barnabe (np)]

If a link opened in a new tab contains a Java applet, all others tabs get that
tab's URL, security icon, etc.

1. Force links that open in new windows to open in new tab. Don't set "Select
tabs opened from links".
2. Open testcase.
3. Click
4. Go back to first tab

The secure site's URL and security icon appear in the first tab. This appears in
the Javascript Console:

Error: focusedWindow has no properties
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 551

Comment 1

[Jason Barnabe (np)]

Attachment: testcase

Comment 2

[Daniel Veditz [:dveditz]]

What version? trunk? branch? WFM in FF 1.0.2

Comment 3

[Jason Barnabe (np)]

Trunk. Just like I specified in the Version field. Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050324 Firefox/1.0+

Comment 4

[Daniel Veditz [:dveditz]]

I've learned not to trust the fields, so many people just leave the defaults.

Comment 5

[Jason Barnabe (np)]

http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/tabbrowser.xml#548
This code is using document.commandDispatcher.focusedWindow, which is null in
this situation. That code was added by bug 254056, which is the exact timeframe
that this bug appeared (20050309).

I'd make a patch to add a null check myself, but it seems to me that
focusedWindow should never be null.

Comment 6

[Daniel Veditz [:dveditz]]

Confirming.

Does not happen if you Ctrl-click to open in a new tab (foreground or
background), it must be set to open new windows in tab.

Comment 7

[Jason Barnabe (np)]

"Select new tabs opened from links" doesn't seem to affect links that want to
open in new windows any more - it will always select the new tab. So there's no
way to reproduce at the moment.

Comment 8

[Jason Barnabe (np)]

Actually, this behaviour is controlled by browser.tabs.loadDivertedInBackground
now, but it seems to be fixed. The testcase's link no longer has a Java applet
in it either, I'll update that.

Comment 9

[Jason Barnabe (np)]

Attachment: testcase

Comment 10

[Mike Shaver (:shaver emeritus)]

Vlad: can you take a look at this (and other such
focusedWindow-has-no-properties tabBrowser issues)?

Comment 11

[Brian Ryner (not reading)]

I'm not seeing this in a 1.8 branch build, WinXP with Sun Java 1.5.0_02.

Comment 12

[Jason Barnabe (np)]

I don't see it either anymore. The patch for bug 287467 added a null check for
the code I mentionned in comment 5. Still don't know why focusedWindow is ever
null, though.

Comment 13

[Brian Ryner (not reading)]

Resolving FIXED then.

Comment 14

[chris hofmann]

adding some status whiteboard foo to get this of the list of bugs that need to be considered for 1.8 branch