288082 - Native theme code doesn't understand menubuttons

Status: RESOLVED WONTFIX

(Core :: Widget: Win32, defect)

Description

[[e-mail]]

Unlike ordinary buttons, menubuttons don't have hover and active state, instead
they have hover and open state. Dual menubuttons of course have hover, active
and open state. Before hover and active were heirarchical this didn't matter a
lot because hovering or clicking on menuitems was ignored by the button, but now
all native theme implementations are erroneously reacting to the hover and
active states on their menuitems.

You can see the problem by opening the Back button menu and hovering over the
back items - in some cases mousing out of the window causes an effect too!

If you remove or override the -moz-appearance styles then you should see a
consistent effect (which is to display open as active hover).

I imagine the XP part of the fix is to create an IsOpenButton utility method
which all of the individual implementations use to force active hover.

We may also want to inherit the open attribute into the dual button.

Comment 2

[Kai Liu]

Attachment: WIP

This works; there are just some loose ends to tie up, like RTL compatibility for dual buttons and I need to audit what CSS needs to be changed.

Comment 3

[Kai Liu]

And I'll eventually need someone to help w/ any changes that may be needed for Mac as I don't have one; I need to update my Linux box so that I could test this there...

Comment 4

[Kai Liu]

Okay, making the dual buttons RTL-compatible will be trivial once bug 441452 lands.

There is one issue that needs some discussing.  When using native dual/split button rendering, Windows draws a drop-down arrow for the drop button.

Option 1: Implement bug 431666 and don't use a GIF arrow whenever we are themed (the default theme selector is inappropriate here) and using a dualbutton drop-down.

Option 2: Draw arrows in the native theme code so that we can stop relying on GIF/PNG drop-down arrows completely.  If done right, this means that we could also fix all those problems with arrows on dark backgrounds.  It's unclear when (or if) support for using SVG for UI stuff would be enabled (and even then, it can't be as efficient as this), so I strongly favor this option.

Comment 5

[Dão Gottwald [:dao]]

The second option certainly sounds more appealing (and more complex).

Comment 6

[[e-mail]]

(In reply to comment #4)
> Option 2: Draw arrows in the native theme code so that we can stop relying on
> GIF/PNG drop-down arrows completely.
IMHO we can never stop relying on GIF/PNG arrows unless you're prepared to write all native theme code for all current and future GFX ports ;-)

Comment 7

[Kai Liu]

(In reply to comment #6)
> (In reply to comment #4)
> > Option 2: Draw arrows in the native theme code so that we can stop relying on
> > GIF/PNG drop-down arrows completely.
> IMHO we can never stop relying on GIF/PNG arrows unless you're prepared to
> write all native theme code for all current and future GFX ports ;-)
> 

s/completely/completely for the default Windows theme/  :)

Comment 8

[[e-mail]]

(In reply to comment #7)
> s/completely/completely for the default Windows theme/  :)
Except the Windows theme is the global default theme; of course the Mac has its own theme but Unix and OS/2 simply override a selected few files.

Comment 9

[Stephen A Pohl [:spohl]]

Support for menubuttons was removed in bug 1457218.