Closed
Bug 288194
Opened 19 years ago
Closed 16 years ago
XUL <textbox> is too hard to focus
Categories
(Toolkit :: UI Widgets, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: Peter6, Assigned: dao)
References
Details
(Keywords: testcase)
Attachments
(5 files, 1 obsolete file)
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050329 Firefox/1.0+ repro: 1.Open Firefox (probably the same in Seamonkey) 2.Move the mouse over the locationbar to focus 3.The area that takes focus is only the width and height of the text 4.html <input>, <textarea> takes focus as soon as the mouse is inside the border This behaviour makes it very easy to miss the focusarea and type stuff that never is displayed becaused you missed the focus again. expected: the XUL <textbox> should accept focus inside the border, like <input> and <textarea>
Reporter | ||
Comment 1•19 years ago
|
||
Screenshot of where onmouseclick sets focus to the box. Top: XUL <textbox> Bottom: html <input type="text"> (same for any other form element)
Reporter | ||
Comment 2•19 years ago
|
||
? FF1.1 (I'm not sure if that's allowed) I have been mishitting <textbox> -es way too long
Flags: blocking-aviary1.1?
Comment 3•19 years ago
|
||
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050325 Firefox/1.0+ WFM
Comment 4•19 years ago
|
||
I thought it was the "Find as you type" bug coming back again. Was that one even ever fixed? You know, the bug where FAYT just started for no good reason.
Reporter | ||
Comment 5•19 years ago
|
||
(In reply to comment #4) > I thought it was the "Find as you type" bug coming back again. Was that one even > ever fixed? You know, the bug where FAYT just started for no good reason. This misfocus may well be the reason for FAYT to start
Comment 6•19 years ago
|
||
This focus issue is really very irritating, I always have to check twice to make sure that find toolbar has focus.
Reporter | ||
Comment 7•19 years ago
|
||
I enlarged the Findbar 10 times to show the actuall number pixels that won't accept focus at mousedown.
Reporter | ||
Comment 8•19 years ago
|
||
CC Neil Deakin Any chance you could help us Neil?
Reporter | ||
Comment 9•19 years ago
|
||
Oops, wrong Neil CC's This time better (I hope)
Comment 10•19 years ago
|
||
I'm not Neil Deakin either but I suspect you'd need to programatically focus the inner input whenever the mouse is clicked anywhere within the xul textbox; currently the context menu code has a specific workaround to focus it.
Reporter | ||
Comment 11•19 years ago
|
||
(In reply to comment #10) > I'm not Neil Deakin either but I suspect you'd need to programatically focus the > inner input whenever the mouse is clicked anywhere within the xul textbox; > currently the context menu code has a specific workaround to focus it. Boris suggested me to CC you. I know, an easy hack is adding onclick="focus();" to every textbox , but it isn't solving the problem offcourse.
Comment 12•19 years ago
|
||
(In reply to comment #11) >I know, an easy hack is adding onclick="focus();" to every textbox, but it >isn't solving the problem of course. Then what sort of solution are you looking for? http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/textbox.xml#97 is a central location where we can add mouse handlers to every textbox. Note: I would a) prefer to use mousedown rather then click b) directly focus the inputField c) check that the inputField is not disabled first.
Reporter | ||
Comment 13•19 years ago
|
||
(In reply to comment #12) > Then what sort of solution are you looking for? I am looking for the <textbox> to get focus if mousedown happens anywhere inside or on the border of the element. Equal to the mousedown behaviour on any formelement in html > http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/textbox.xml#97 > is a central location where we can add mouse handlers to every textbox. > Note: I would a) prefer to use mousedown rather then click b) directly focus the > inputField c) check that the inputField is not disabled first. I'm a no-coder :-(
Updated•19 years ago
|
Assignee: nobody → bugs.mano
Updated•19 years ago
|
Status: NEW → ASSIGNED
Comment 15•19 years ago
|
||
Reporter | ||
Comment 16•19 years ago
|
||
the bottom 2 boxes is how it "should" work.
Updated•19 years ago
|
Target Milestone: mozilla1.8beta2 → mozilla1.8beta3
Comment 17•19 years ago
|
||
(In reply to comment #6) > This focus issue is really very irritating, I always have to check twice to make > sure that find toolbar has focus. I have to check twice to make sure it DOESN'T have focus.
Comment 18•19 years ago
|
||
Not a blocker, but patches are still welcome.
Flags: blocking-aviary1.1? → blocking-aviary1.1-
Comment 19•19 years ago
|
||
*** Bug 289841 has been marked as a duplicate of this bug. ***
Comment 20•19 years ago
|
||
Well, what seems to work for the url bar for me is: .autocomplete-textbox-container { -moz-box-align: stretch; }, instead of -moz-box-align: center;
Comment 21•19 years ago
|
||
(In reply to comment #20) > Well, what seems to work for the url bar for me is: > .autocomplete-textbox-container { > -moz-box-align: stretch; }, instead of -moz-box-align: center; I thought that was necessary to work properly with large fonts...
Updated•19 years ago
|
Target Milestone: mozilla1.8beta3 → mozilla1.9alpha
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
Assignee | ||
Comment 22•16 years ago
|
||
Assignee: mano → dao
Attachment #340430 -
Flags: review?(enndeakin)
Assignee | ||
Updated•16 years ago
|
Target Milestone: mozilla1.9alpha1 → ---
Comment 23•16 years ago
|
||
Comment on attachment 340430 [details] [diff] [review] patch >+ if (event.originalTarget == this || >+ /(?:\s|^)textbox-input-box(?:\s|$)/.test(event.originalTarget.className)) >+ this.inputField.focus(); Why can't you just add an anonid to the box, or just use this.inputField.parentNode here?
Assignee | ||
Comment 24•16 years ago
|
||
I'd have to add the anonid to different bindings, let alone bindings that we don't control. But inputField.parentNode seems fine.
Assignee | ||
Comment 25•16 years ago
|
||
Attachment #340668 -
Flags: review?(enndeakin)
Assignee | ||
Updated•16 years ago
|
Attachment #340430 -
Attachment is obsolete: true
Attachment #340430 -
Flags: review?(enndeakin)
Updated•16 years ago
|
Attachment #340668 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 26•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/60221b1e9513
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Assignee | ||
Updated•16 years ago
|
Component: XUL → XUL Widgets
Product: Core → Toolkit
QA Contact: xptoolkit.widgets → xul.widgets
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•