288726 - C_Finalize status not checked in SECMOD_CancelWait

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

I found the following problem in pk11util.c by looking at compiler warnings
(gcc) . The bug is that crv is being assigned CKR_OK, instead of being tested.
There is no doubt about the fix, so I will check it in.

	crv = PK11_GETTAB(mod)->C_Finalize(NULL);
	/* ok, we slammed the module down, now we need to reinit it in case
	 * we intend to use it again */
	if (crv = CKR_OK) {
	    secmod_ModuleInit(mod);
	} else {
	    /* Finalized failed for some reason,  notify the application
	     * so maybe it has a prayer of recovering... */
	    PORT_SetError(PK11_MapError(crv));
	    rv = SECFailure;
	}

Comment 1

[Julien Pierre]

Attachment: fix as checked in

Checking in pk11util.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11util.c,v  <--  pk11util.c
new revision: 1.49; previous revision: 1.48
done

Comment 2

[Wan-Teh Chang]

*** Bug 289047 has been marked as a duplicate of this bug. ***

Comment 3

[Frank Wein [:mcsmurf]]

*** Bug 355840 has been marked as a duplicate of this bug. ***