Last Comment Bug 355840 - typo in pk11util code
: typo in pk11util code
Status: RESOLVED DUPLICATE of bug 288726
:
Product: SeaMonkey
Classification: Client Software
Component: Security (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Daniel Veditz [:dveditz]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-07 06:05 PDT by jose
Modified: 2006-10-07 14:46 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description jose 2006-10-07 06:05:20 PDT
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.7.13/source/

there's a small typo in the pk11util code that has unknown consequences. it looks like a reliability bug, but im not entirely sure.

here's a patch:

--- security/nss/lib/pk11wrap/pk11util.c.orig   Sat Oct  7 08:58:16 2006
+++ security/nss/lib/pk11wrap/pk11util.c        Sat Oct  7 08:58:26 2006
@@ -1128,7 +1128,7 @@
        crv = PK11_GETTAB(mod)->C_Finalize(NULL);
        /* ok, we slammed the module down, now we need to reinit it in case
         * we intend to use it again */
-       if (crv = CKR_OK) {
+       if (crv == CKR_OK) {
            secmod_ModuleInit(mod);
        } else {
            /* Finalized failed for some reason,  notify the application

Reproducible: Always




found via google codesearch and verified in the latest sources.
Comment 1 Frank Wein [:mcsmurf] 2006-10-07 14:46:24 PDT
Thanks for reporting, but this already been fixed :). Mozilla 1.7.13 is a quite old codebase.

*** This bug has been marked as a duplicate of 288726 ***

Note You need to log in before you can comment on or make changes to this bug.