Closed Bug 288738 Opened 19 years ago Closed 19 years ago

[Mac] Nearly every keyboard shortcut closes the Page Info window

Categories

(Firefox :: Page Info Window, defect, P2)

Product:
Firefox
Component:
Page Info Window
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox1.5

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.84 KB, patch
mconnor
: review+
neil
: superreview+
Details | Diff | Splinter Review 
Nice regression from bug 195492.
FYI: This happens in the suite as well.
Assignee: bugs → bugs.mano
Target Milestone: --- → Firefox1.1
Attached patch patch — — Splinter Review 
for browser/ i'm also #ifdefing the keybinding (as in dialog.xml)
Attachment #179366 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #179366 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #179366 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Personally, I don't care for the ifdef. It'll just make it more difficult to
maintain the two seperate copies of page info.
Comment on attachment 179366 [details] [diff] [review]
patch

meta is defined on more than OS X, but we only want this shortcut for OS X.
Attachment #179366 - Flags: review?(mconnor) → review+
Checking in browser/base/content/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.22; previous revision: 1.21
done
Checking in xpfe/browser/resources/content/pageInfo.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.55; previous revision: 1.54
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Summary: [Mac Only?] Nearly every keyboard shortcut closes the Page Info window → [Mac] Nearly every keyboard shortcut closes the Page Info window
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: