239218 - Menus are nonfunctional when 'tools' have focus (Downloads / Extensions / Theme Managers, JavaScript Console and Page Info window)

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P1)

Description

[kaldari]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6) Gecko/20040206 Firefox/0.8
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.6) Gecko/20040206 Firefox/0.8

When any of the items in the Tools menu are open and focused (except the DOM
Inspector) the menubars don't work (nor do they appear to be disabled).

Reproducible: Always
Steps to Reproduce:
1.Go to the tools menu and select Downloads, JavaScript Console, or Page Info.
2.Go to the File menu and select New Window.

Actual Results:  
Nothing happens.

Expected Results:  
Created a new browser window and changed focus to the new window.

Related to bug 232673.

Comment 1

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7b) Gecko/20040404
Firefox/0.8.0+

I see the same behaviour.

Ben.

Comment 2

[Asaf Romano (gone)]

This is a dupe of bug 228615

Comment 3

[riscky]

Isn't this basically bug 21296

Comment 4

[kaldari]

Bug 21296 is about menus not being active when modal dialog boxes are displayed. In this bug, menus 
are active, but they don't work.

I could see this bug being a broader case of bug 228615, but I don't think either this bug or bug 
228615 are duplicates of bug 21296.

Comment 5

[kaldari]

Actually, I could be wrong. I'm not exactly sure what bug 21296 encompasses. Nor does it seem that 
many of the people discussing that bug know what it emcompasses. Without knowing more about the 
back-end of things I can't tell if these bugs are really related or not. Maybe a developer would have 
more insight on this.

Comment 6

[riscky]

Updating the summary so this bug can be found with a simple search...

Also noteint bug 245206 was opened noting that the menu bar fails to work if it
has focus.

Comment 7

[Hiro]

*** Bug 255658 has been marked as a duplicate of this bug. ***

Comment 8

[Carl Tashian]

*** Bug 259553 has been marked as a duplicate of this bug. ***

Comment 9

[Asaf Romano (gone)]

*** Bug 262020 has been marked as a duplicate of this bug. ***

Comment 10

[Daniel Beckham]

Would it be possible to fix this for Mac 1.0?

Comment 11

[Adam W]

> Would it be possible to fix this for Mac 1.0?

Just noting that this bug is still present in 1.0...  

Comment 12

[Frankie]

*** Bug 263434 has been marked as a duplicate of this bug. ***

Comment 13

[Jo Hermans]

bug 273217 will partially fix it (disabling the items that should not be
accesible). But the problem remains that some items aren't accessible, although
they shouldn't.

Comment 14

[Asaf Romano (gone)]

i'm on it

Comment 15

[Asaf Romano (gone)]

Attachment: patch v1

*extra fun*.

There are still some nits to fix (such as not opening the openlocation window
on mac), but this is the first 'big' step.

Comment 16

[Asaf Romano (gone)]

*** Bug 282431 has been marked as a duplicate of this bug. ***

Comment 17

[Asaf Romano (gone)]

Mike, I understand that this patch is somewhat a bloat; but really, this is our
most annoying visible issue on mac, it worths the Xks it would take (the scripts
are not included per window...).

Comment 18

[Asaf Romano (gone)]

*** Bug 245206 has been marked as a duplicate of this bug. ***

Comment 19

[Asaf Romano (gone)]

*** Bug 283033 has been marked as a duplicate of this bug. ***

Comment 20

[:Gavin Sharp [email: [e-mail]]]

*** Bug 283263 has been marked as a duplicate of this bug. ***

Comment 21

[Asaf Romano (gone)]

*** Bug 283254 has been marked as a duplicate of this bug. ***

Comment 22

[Asaf Romano (gone)]

*** Bug 283630 has been marked as a duplicate of this bug. ***

Comment 23

[Matthias Versen [:Matti]]

*** Bug 284468 has been marked as a duplicate of this bug. ***

Comment 24

[:Gavin Sharp [email: [e-mail]]]

*** Bug 284945 has been marked as a duplicate of this bug. ***

Comment 25

[:Gavin Sharp [email: [e-mail]]]

*** Bug 286819 has been marked as a duplicate of this bug. ***

Comment 26

[Elmar Ludwig]

*** Bug 287432 has been marked as a duplicate of this bug. ***

Comment 27

[:Gavin Sharp [email: [e-mail]]]

*** Bug 288388 has been marked as a duplicate of this bug. ***

Comment 28

[Asaf Romano (gone)]

Comment on attachment 172619 [details] [diff] [review]
patch v1

better fix on the way...

Comment 29

[Asaf Romano (gone)]

Attachment: part 1....

Mike, I would like to get this in before I continue to hack this ****.

This:
  * Get rid of macBrowserOverlay-on-browser.xul
  * Make macBrowserOverlay window-independent

Comment 30

[Asaf Romano (gone)]

Comment on attachment 179309 [details] [diff] [review]
part 1....

baah, wrong diff.

Comment 31

[Asaf Romano (gone)]

Attachment: part 1...

...see comment 29

Comment 32

[Asaf Romano (gone)]

Comment on attachment 179310 [details] [diff] [review]
part 1...

hmm, not enough.

Comment 33

[Asaf Romano (gone)]

Attachment: more...

JS Sucks.

Comment 34

[Asaf Romano (gone)]

*** Bug 232673 has been marked as a duplicate of this bug. ***

Comment 35

[Asaf Romano (gone)]

Attachment: more...

Comment 36

[Asaf Romano (gone)]

Attachment: more...

Comment 37

[Asaf Romano (gone)]

Comment on attachment 179370 [details] [diff] [review]
more...

I will patch other windows once this one is in.

Comment 38

[Elmar Ludwig]

*** Bug 289277 has been marked as a duplicate of this bug. ***

Comment 39

[Asaf Romano (gone)]

Attachment: patch (add missing #ifdef)

Comment 40

[Mike Connor [:mconnor]]

okay, so other than renaming Startup() and Shutdown() which I'm not sure is a
good plan, where is this browserMountPoints.inc?

Comment 41

[Mike Connor [:mconnor]]

and downloadManagerOverlay.xul too.

Comment 42

[Asaf Romano (gone)]

*** Bug 290549 has been marked as a duplicate of this bug. ***

Comment 43

[Asaf Romano (gone)]

Attachment: [checked in] well-diffed patch

Comment 44

[Mike Connor [:mconnor]]

Comment on attachment 180965 [details] [diff] [review]
[checked in] well-diffed patch

>@@ -1558,18 +1562,18 @@ function openLocation()
> {
>   if (gURLBar && !gURLBar.parentNode.parentNode.collapsed &&
>       !(window.getComputedStyle(gURLBar.parentNode, null).display == "none")) {
>     gURLBar.focus();
>     gURLBar.select();
>   }
>   else {
> #ifdef XP_MACOSX
>-    if (window.location.href == "chrome://browser/content/hiddenWindow.xul") {
>-      // If no windows are active, open a new one. 
>+    if (window.location.href != getBrowserURL()) {
>+      // If it's not a browser window, open a new one. 
>       window.openDialog("chrome://browser/content/", "_blank", "chrome,all,dialog=no", "about:blank");
>     }
>     else
> #endif
>       openDialog("chrome://browser/content/openLocation.xul", "_blank", "chrome,modal,titlebar", window);
>   }
> }

I'd rather fix openLocation.xul to open a new window if needed than
automatically open a new browser window, but I'll let this go in assuming you
file a followup bug on making this saner and respecting the single-window
behaviour some people rely on.

Please make sure the other windows get hooked up ASAP.

Comment 45

[Asa Dotzler [:asa]]

Comment on attachment 180965 [details] [diff] [review]
[checked in] well-diffed patch

a=asa

Comment 46

[Asaf Romano (gone)]

Checking in base/jar.mn;
/cvsroot/mozilla/browser/base/jar.mn,v  <--  jar.mn
new revision: 1.87; previous revision: 1.86
done
Checking in base/content/aboutDialog.xul;
/cvsroot/mozilla/browser/base/content/aboutDialog.xul,v  <--  aboutDialog.xul
new revision: 1.22; previous revision: 1.21
done
Checking in base/content/browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.45; previous revision: 1.44
done
Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.409; previous revision: 1.408
done
Checking in base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.259; previous revision: 1.258
done
RCS file: /cvsroot/mozilla/browser/base/content/browserMountPoints.inc,v
done
Checking in base/content/browserMountPoints.inc;
/cvsroot/mozilla/browser/base/content/browserMountPoints.inc,v  <-- 
browserMountPoints.inc
initial revision: 1.1
done
Checking in base/content/contents.rdf;
/cvsroot/mozilla/browser/base/content/contents.rdf,v  <--  contents.rdf
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/browser/base/content/downloadManagerOverlay.xul,v
done
Checking in base/content/downloadManagerOverlay.xul;
/cvsroot/mozilla/browser/base/content/downloadManagerOverlay.xul,v  <-- 
downloadManagerOverlay.xul
initial revision: 1.1
done
Checking in base/content/hiddenWindow.xul;
/cvsroot/mozilla/browser/base/content/hiddenWindow.xul,v  <--  hiddenWindow.xul
new revision: 1.4; previous revision: 1.3
done
Checking in base/content/macBrowserOverlay.xul;
/cvsroot/mozilla/browser/base/content/macBrowserOverlay.xul,v  <-- 
macBrowserOverlay.xul
new revision: 1.6; previous revision: 1.5
done
Checking in base/content/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageInfo.xul,v  <--  pageInfo.xul
new revision: 1.23; previous revision: 1.22
done

Comment 47

[Asaf Romano (gone)]

Attachment: extensions / themes manager + js console

Those are the last windows i'm going to fix here.

We still need to [find a way to] fix the preferences window, but i'm going to
move that part to a new bug.

Comment 48

[Asaf Romano (gone)]

Attachment: final bits

Comment 49

[Mike Connor [:mconnor]]

Comment on attachment 181233 [details] [diff] [review]
final bits

r=me, as long as you change the comments referring to browser-scripts.inc to
read global-scripts.inc

Comment 50

[Asa Dotzler [:asa]]

Comment on attachment 181233 [details] [diff] [review]
final bits

a=asa

Comment 51

[Asaf Romano (gone)]

Checking in base/jar.mn;
/cvsroot/mozilla/browser/base/jar.mn,v  <--  jar.mn
new revision: 1.88; previous revision: 1.87
done
Removing base/content/browser-scripts.inc;
/cvsroot/mozilla/browser/base/content/browser-scripts.inc,v  <-- 
browser-scripts.inc
new revision: delete; previous revision: 1.8
done
Checking in base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.260; previous revision: 1.259
done
Checking in base/content/contents.rdf;
/cvsroot/mozilla/browser/base/content/contents.rdf,v  <--  contents.rdf
new revision: 1.7; previous revision: 1.6
done
RCS file: /cvsroot/mozilla/browser/base/content/extensionsManagerOverlay.xul,v
done
Checking in base/content/extensionsManagerOverlay.xul;
/cvsroot/mozilla/browser/base/content/extensionsManagerOverlay.xul,v  <-- 
extensionsManagerOverlay.xul
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/base/content/global-scripts.inc,v
done
Checking in base/content/global-scripts.inc;
/cvsroot/mozilla/browser/base/content/global-scripts.inc,v  <--  global-scripts.inc
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/browser/base/content/jsConsoleOverlay.xul,v
done
Checking in base/content/jsConsoleOverlay.xul;
/cvsroot/mozilla/browser/base/content/jsConsoleOverlay.xul,v  <-- 
jsConsoleOverlay.xul
initial revision: 1.1
done
Checking in base/content/macBrowserOverlay.xul;
/cvsroot/mozilla/browser/base/content/macBrowserOverlay.xul,v  <-- 
macBrowserOverlay.xul
new revision: 1.7; previous revision: 1.6
done

Comment 52

[Elmar Ludwig]

*** Bug 293443 has been marked as a duplicate of this bug. ***

Comment 53

[Elmar Ludwig]

*** Bug 293644 has been marked as a duplicate of this bug. ***

Comment 54

[Kevin Brosnan]

*** Bug 294706 has been marked as a duplicate of this bug. ***

Comment 55

[:Gavin Sharp [email: [e-mail]]]

*** Bug 295923 has been marked as a duplicate of this bug. ***

Comment 56

[:Gavin Sharp [email: [e-mail]]]

*** Bug 297021 has been marked as a duplicate of this bug. ***

Comment 57

[:Gavin Sharp [email: [e-mail]]]

*** Bug 298294 has been marked as a duplicate of this bug. ***

Comment 58

[Dave Townsend [:mossop]]

*** Bug 301840 has been marked as a duplicate of this bug. ***

Comment 59

[Jo Hermans]

*** Bug 303831 has been marked as a duplicate of this bug. ***

Comment 60

[Dave Townsend [:mossop]]

*** Bug 310106 has been marked as a duplicate of this bug. ***