Need to disable the "+" button/menu items in History/Top10/etc.

RESOLVED FIXED in Camino1.5

Status

Camino Graveyard
Bookmarks
P3
normal
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Stuart Morgan)

Tracking

({fixed1.8.1.1})

unspecified
Camino1.5
PowerPC
Mac OS X
fixed1.8.1.1

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

4.63 KB, patch
froodian (Ian Leue)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
I swear I've seen a bug on this already, but I can't find it now.

The "+" button/menu at the bottom of the bookmarks manager needs to be disabled
when in History.  None of those menu items are relevant to History--you can't
add a folder, bookmark, or separator to History--and they currently act on
Bookmarks (i.e., Add Separator adds a separator over in Bookmarks when you
select it in History).
I'm going to move this from History to Bookmarks for housekeeping purposes,
because that menu/button also needs to disabled in other panes of the BM: Top
10, Rendezvous, Addressbook, as well as History.

By 1.0?
Component: History → Bookmarks
Summary: Need to disable the "+" button/menu items in History → Need to disable the "+" button/menu items in History/Top10/etc.

Comment 2

12 years ago
Taking.
Assignee: pinkerton → sfraser_bugs

Updated

12 years ago
Priority: -- → P3
Target Milestone: --- → Camino1.0
-> 1.1
Target Milestone: Camino1.0 → Camino1.1

Comment 4

11 years ago
Likewise, the normal menu items (specifically, "Add Bookmark Folder..." in the Bookmarks menu) should also be disabled. Whether or not we want to keep "Add Bookmark" enabled is something that should probably be discussed.

Oh, and the action menu next to the + should also be disabled, since all three of its items are disabled when history is active anyway.

This, coupled with a few other "when history is up, disable/change stuff" bugs (like bug 335979 and bug 316835, and the related bug 318931), is screaming for a historyIsInView method on the appropriate class (BrowserWindowController?).

We really need a meta tracking bug for all these validation issues.

cl

Updated

11 years ago
Blocks: 341853

Comment 5

11 years ago
->me (assuming you're not actually working on this, Simon).
Assignee: sfraser_bugs → stridey
QA Contact: toolbars
Whiteboard: [good first bug]

Comment 6

11 years ago
Assume that I'm not working on anything, unless I start making noises to that effect in a bug.
(Assignee)

Comment 7

11 years ago
Created attachment 242374 [details] [diff] [review]
fixes buttons

Fixes the buttons. Specifically:
- Enables/disables them at the appropriate times
- Fixes the buttons to actually respect being disabled
- Fixes a bug causing the action menu to be empty for the read-only collections

Menu items aren't addressed here, since it's entirely unrelated from a code standpoint; that should be done in either bug 175748 or a follow-up bug.
Assignee: stridey → stuart.morgan
Status: NEW → ASSIGNED
Attachment #242374 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #242374 - Flags: review? → review?(stridey)

Comment 8

11 years ago
Comment on attachment 242374 [details] [diff] [review]
fixes buttons

r=me
Attachment #242374 - Flags: superreview?(mikepinkerton)
Attachment #242374 - Flags: review?(stridey)
Attachment #242374 - Flags: review+
Comment on attachment 242374 [details] [diff] [review]
fixes buttons

sr=pink
Attachment #242374 - Flags: superreview?(mikepinkerton) → superreview+

Comment 10

11 years ago
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

Updated

11 years ago
Keywords: fixed1.8.1.1

Updated

11 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.