288814 - Need to disable the "+" button/menu items in History/Top10/etc.

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect, P3)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I swear I've seen a bug on this already, but I can't find it now.

The "+" button/menu at the bottom of the bookmarks manager needs to be disabled
when in History.  None of those menu items are relevant to History--you can't
add a folder, bookmark, or separator to History--and they currently act on
Bookmarks (i.e., Add Separator adds a separator over in Bookmarks when you
select it in History).

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm going to move this from History to Bookmarks for housekeeping purposes,
because that menu/button also needs to disabled in other panes of the BM: Top
10, Rendezvous, Addressbook, as well as History.

By 1.0?

Comment 2

[Simon Fraser [no longer active]]

Taking.

Comment 3

[Samuel Sidler (old account; do not CC)]

-> 1.1

Comment 4

[Chris Lawson (gone)]

Likewise, the normal menu items (specifically, "Add Bookmark Folder..." in the Bookmarks menu) should also be disabled. Whether or not we want to keep "Add Bookmark" enabled is something that should probably be discussed.

Oh, and the action menu next to the + should also be disabled, since all three of its items are disabled when history is active anyway.

This, coupled with a few other "when history is up, disable/change stuff" bugs (like bug 335979 and bug 316835, and the related bug 318931), is screaming for a historyIsInView method on the appropriate class (BrowserWindowController?).

We really need a meta tracking bug for all these validation issues.

cl

Comment 5

[froodian (Ian Leue)]

->me (assuming you're not actually working on this, Simon).

Comment 6

[Simon Fraser [no longer active]]

Assume that I'm not working on anything, unless I start making noises to that effect in a bug.

Comment 7

[Stuart Morgan]

Attachment: fixes buttons

Fixes the buttons. Specifically:
- Enables/disables them at the appropriate times
- Fixes the buttons to actually respect being disabled
- Fixes a bug causing the action menu to be empty for the read-only collections

Menu items aren't addressed here, since it's entirely unrelated from a code standpoint; that should be done in either bug 175748 or a follow-up bug.

Comment 8

[froodian (Ian Leue)]

Comment on attachment 242374 [details] [diff] [review]
fixes buttons

r=me

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 242374 [details] [diff] [review]
fixes buttons

sr=pink

Comment 10

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.