Last Comment Bug 288814 - Need to disable the "+" button/menu items in History/Top10/etc.
: Need to disable the "+" button/menu items in History/Top10/etc.
Status: RESOLVED FIXED
[good first bug]
: fixed1.8.1.1
Product: Camino Graveyard
Classification: Graveyard
Component: Bookmarks (show other bugs)
: unspecified
: PowerPC Mac OS X
P3 normal (vote)
: Camino1.5
Assigned To: Stuart Morgan
:
:
Mentors:
Depends on:
Blocks: 341853
  Show dependency treegraph
 
Reported: 2005-04-02 22:12 PST by Smokey Ardisson (offline for a while; not following bugs - do not email)
Modified: 2006-10-27 17:48 PDT (History)
7 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fixes buttons (4.63 KB, patch)
2006-10-15 20:53 PDT, Stuart Morgan
froodian: review+
mikepinkerton: superreview+
Details | Diff | Splinter Review

Description User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2005-04-02 22:12:20 PST
I swear I've seen a bug on this already, but I can't find it now.

The "+" button/menu at the bottom of the bookmarks manager needs to be disabled
when in History.  None of those menu items are relevant to History--you can't
add a folder, bookmark, or separator to History--and they currently act on
Bookmarks (i.e., Add Separator adds a separator over in Bookmarks when you
select it in History).
Comment 1 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2005-04-03 23:53:10 PDT
I'm going to move this from History to Bookmarks for housekeeping purposes,
because that menu/button also needs to disabled in other panes of the BM: Top
10, Rendezvous, Addressbook, as well as History.

By 1.0?
Comment 2 User image Simon Fraser 2005-04-04 20:23:34 PDT
Taking.
Comment 3 User image Samuel Sidler (old account; do not CC) 2006-02-03 15:19:21 PST
-> 1.1
Comment 4 User image Chris Lawson (gone) 2006-06-18 15:24:54 PDT
Likewise, the normal menu items (specifically, "Add Bookmark Folder..." in the Bookmarks menu) should also be disabled. Whether or not we want to keep "Add Bookmark" enabled is something that should probably be discussed.

Oh, and the action menu next to the + should also be disabled, since all three of its items are disabled when history is active anyway.

This, coupled with a few other "when history is up, disable/change stuff" bugs (like bug 335979 and bug 316835, and the related bug 318931), is screaming for a historyIsInView method on the appropriate class (BrowserWindowController?).

We really need a meta tracking bug for all these validation issues.

cl
Comment 5 User image froodian (Ian Leue) 2006-06-21 20:16:05 PDT
->me (assuming you're not actually working on this, Simon).
Comment 6 User image Simon Fraser 2006-06-22 22:42:44 PDT
Assume that I'm not working on anything, unless I start making noises to that effect in a bug.
Comment 7 User image Stuart Morgan 2006-10-15 20:53:51 PDT
Created attachment 242374 [details] [diff] [review]
fixes buttons

Fixes the buttons. Specifically:
- Enables/disables them at the appropriate times
- Fixes the buttons to actually respect being disabled
- Fixes a bug causing the action menu to be empty for the read-only collections

Menu items aren't addressed here, since it's entirely unrelated from a code standpoint; that should be done in either bug 175748 or a follow-up bug.
Comment 8 User image froodian (Ian Leue) 2006-10-16 22:10:45 PDT
Comment on attachment 242374 [details] [diff] [review]
fixes buttons

r=me
Comment 9 User image Mike Pinkerton (not reading bugmail) 2006-10-18 09:21:34 PDT
Comment on attachment 242374 [details] [diff] [review]
fixes buttons

sr=pink
Comment 10 User image froodian (Ian Leue) 2006-10-18 10:14:07 PDT
Checked in on 1.8branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.