Replace Dictionary.com with Answers.com for dictionary lookup.

RESOLVED FIXED

Status

()

Firefox
Search
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Ben Goodger (use ben at mozilla dot org for email), Assigned: Ben Goodger (use ben at mozilla dot org for email))

Tracking

({fixed1.8})

unspecified
fixed1.8
Points:
---
Bug Flags:
blocking1.8b5 +
blocking-aviary1.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Dictionary.com's abusive policy towards users with respect to advertising and
popups is inconsistent with Firefox's goals. To make things worse, they not only
show popup ads, they maliciously work around Firefox's popup blocker, despite
the fact that we are publicizing their service from our application. 

This must end, and so I am replacing D.c with Answers.com - a simpler, smoother
interface with less obtrusive advertising and no popups. 

Some changes were required to the Internet Search Service to support answer's
query format.
Status: NEW → ASSIGNED
Flags: blocking-aviary1.1+
Created attachment 179892 [details] [diff] [review]
patch
Flags: blocking1.8b4+
Chris, let me know when we're good to go on this one.

Comment 3

12 years ago
We're good to go.
Attachment #179892 - Flags: review?(benjamin)
Hi Benjamin - requesting review here, nsInternetSearchService was not handling
search engines whose parameter format included no query string. Answers.com uses:

http://answers.com/<param>

.. this patch updates the installers, bookmarks file, etc. and makes nsISS
handle this query format. 

Comment 5

12 years ago
This affects the following locales (on trunk, at least):

ar
bg
el
en-GB
es-AR
eu
ga-IE
gu-IN
hu
hy-AM
ja
ja-JP-mac
ko
mn
nl
ro
sk
sq
sv-SE
tr
zh-CN
zh-TW

Luckily, it seems that nobody renamed dictionary.src, so the removal code should
work for localized builds, too.
I shouldn't check the if else + - stuff at 1 am, though.
Comment on attachment 179892 [details] [diff] [review]
patch

Something is wrong with the bookmarks.html patch (Quicksearch is split across
two lines). Otherwise this looks fine.
Attachment #179892 - Flags: review?(benjamin) → review+
Attachment #179892 - Flags: approval1.8b4?
Attachment #179892 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #179892 - Flags: approval1.8b4?
Attachment #179892 - Flags: approval1.8b4+
Attachment #179892 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #179892 - Flags: approval1.8b4? → approval1.8b4+
landed branch and trunk. 
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 8

12 years ago
(In reply to comment #7)
> landed branch and trunk. 

This landing broke the tree.

/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/obj/config/nsinstall
-R
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/bookmarks.html
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/localstore.rdf
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/search.rdf
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/unix/mimeTypes.rdf
../../dist/bin/defaults/profile
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/obj/config/nsinstall
-R
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/chrome/userChrome-example.css
/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/profile/chrome/userContent-example.css
../../dist/bin/defaults/profile/chrome
gmake[4]: *** No rule to make target
`/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/browser/locales/en-US/searchplugins/answers.src',
needed by `libs'.  Stop.
gmake[4]: Leaving directory
`/builds/tinderbox/Fx-Mozilla1.8/Linux_2.6.12-1.1398_FC4_Depend/mozilla/obj/browser/locales'
gmake[3]: *** [libs] Error 2

Updated

12 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

12 years ago
Attachment #179892 - Flags: approval1.8b4+

Comment 9

12 years ago
Comment on attachment 179892 [details] [diff] [review]
patch

I'm backing out your check-in in a couple of minutes.  The tree has been busted
for an hour and a half.

Comment 10

12 years ago
(In reply to comment #9)
> (From update of attachment 179892 [details] [diff] [review] [edit])
> I'm backing out your check-in in a couple of minutes.  The tree has been busted
> for an hour and a half.

Scott suggested a blank answers.src file be added to fix the bustage.  I'm
having him land such on trunk and branch with r+a=chase@mozilla.org.

Ben, *watch the tree* after you land your patches to help us keep the tree green
for others.

Comment 11

12 years ago
Comment on attachment 179892 [details] [diff] [review]
patch

Upon closer inspection, your branch check-in contains at least two extra
patches that apparently were accidentally committed.  One of these was the
channel-prefs.js change which *definitely* shouldn't have gone in yet.

Comment 12

12 years ago
quicksearch is checked in split, just as is the mozillazine icon in bookmarks.html,
it seems.
Group: Marketing Private
checked in a fix for split lines. 
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
The search plugin sends queries with the wrong encoding - see bug 305756.
mozilla/browser/locales/en-US/searchplugins/dictionary.src was not removed from
CVS, while dictionary.png was.

Updated

12 years ago
Keywords: fixed1.8

Comment 16

12 years ago
Suggest looking into Wiktionary at some point
(http://en.wiktionary.org/wiki/Main_Page)
Text should read "Answers.com" not "Dictionary".

Should I file a separate bug, Ben or reopen this one?
You need to log in before you can comment on or make changes to this bug.