289553 - Dynamically changing the favicon doesn't update the icon in the tab.

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alexander Larsson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0

If you dynamically update the favicon by removing/re-adding a rel="icon" link in
the head the icon in the tab doesn't update. It does however update in the
location bar. See the URL for an example.

Reproducible: Always

Steps to Reproduce:
1. Make sure you have more than one tab (so tabs are visible)
2. Load http://people.redhat.com/~alexl/files/dynfavicon.html
3. click on "changed icon" button


Actual Results:  
favicon changed in location entry (next to url), but not in the tab.

Expected Results:  
Icon should have changed in the tab too.

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050408
Firefox/1.0+

confirmed ->New

Comment 2

[Jo Hermans]

even worse : bug 260550 (label in bookmarks file is never updated at all)

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

port of seamonkey patch

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 180338 [details] [diff] [review]
patch

a=asa

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in

Comment 6

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050426
Firefox/1.0+ 10:51PDT build

Verfied

Comment 7

[tabmix.onemen]

after reload a tab i get this error:
Error: listener.setIcon is not a function
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 795

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #7)
> after reload a tab i get this error:
> Error: listener.setIcon is not a function
> Source File: chrome://global/content/bindings/tabbrowser.xml
> Line: 795

Any chance this might be a tab extension related.
I'm not seeing any JSC warning, not with a soft nor hard reload

Comment 9

[tabmix.onemen]

(In reply to comment #8)
> (In reply to comment #7)
> > after reload a tab i get this error:
> > Error: listener.setIcon is not a function
> > Source File: chrome://global/content/bindings/tabbrowser.xml
> > Line: 795
> 
> Any chance this might be a tab extension related.
> I'm not seeing any JSC warning, not with a soft nor hard reload
> 

yes
when i disabled TabMix the error dosn't show