[FIX]Crash related to PrivilegeManager

RESOLVED FIXED in mozilla1.8beta2

Status

()

P1
critical
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: bugzilla, Assigned: bzbarsky)

Tracking

(4 keywords)

Trunk
mozilla1.8beta2
x86
Windows XP
crash, crashreportid, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
I've cornered a crash which is caused either by
	netscape.security.PrivilegeManager.enablePrivilege("UniversalBrowserWrite");
or	netscape.security.PrivilegeManager.revertPrivilege("UniversalBrowserWrite");

Mozilla 1.8b2 build 2005041106 under XP Pro SP2 here.

1 TalkbackID incident: 5020066 
(there are 3 others talkbackid but I did not get the talkback id)

Reduced testcase coming.
(Reporter)

Comment 1

14 years ago
Created attachment 180433 [details]
Reduced testcase

Load this testcase, then unload the page by going to another url.

On an unload event, the testcase execute these instructions:

       
netscape.security.PrivilegeManager.enablePrivilege("UniversalBrowserWrite");
	window.locationbar.visible = originalLocationbar ;
	window.menubar.visible = originalMenubar ;
	window.personalbar.visible = originalPersonalbar ;
	window.statusbar.visible = originalStatusbar ;
	window.toolbar.visible = originalToolbar ;
netscape.security.PrivilegeManager.revertPrivilege("UniversalBrowserWrite");
(Reporter)

Updated

14 years ago
Keywords: clean-report, testcase
Summary: Crash related to PrivilegeManager → Crash related to PrivilegeManager

Updated

14 years ago
Assignee: general → dveditz
Component: General → Security: CAPS
Product: Mozilla Application Suite → Core
QA Contact: general
(Assignee)

Updated

14 years ago
Blocks: 289925
Created attachment 180456 [details] [diff] [review]
Patch

This is a silly mistake in the patch for bug 289643.  In this one case we
forget to set the our param on successful return, and then all heck breaks
lose.

The other change in this diff is just a whitespace change that I meant to do in
bug 289643 and forgot...
(Assignee)

Updated

14 years ago
Attachment #180456 - Flags: superreview?(brendan)
Attachment #180456 - Flags: review?(caillon)
(Assignee)

Updated

14 years ago
Blocks: 289643
Attachment #180456 - Flags: review?(caillon) → review+
(Assignee)

Updated

14 years ago
Assignee: dveditz → bzbarsky
Priority: -- → P1
Summary: Crash related to PrivilegeManager → [FIX]Crash related to PrivilegeManager
Target Milestone: --- → mozilla1.8beta2
Patch checked in.  Gerard, thanks for the excellent testcase.  Made it possible
to find people willing to help debug remotely, if nothing else... ;)
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
*** Bug 289925 has been marked as a duplicate of this bug. ***

Comment 5

14 years ago
*** Bug 290014 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.