29000 - Remove link should be disabled when not in a link

Status: VERIFIED DUPLICATE of bug 68059

(Core :: DOM: Editor, defect, P4)

Description

[sujay]

using 2/23 build of mozilla

1) launch mozilla
2) launch editor
3) insert text
4) make it a link to some site
5) now insert cursor in front of, in between or at the end of this
link
6) Format | Remove link

notice it doesn't remove the link...

so perhaps the issue is that we should disable the "Remove Link" menu
item???

all platforms.

Comment 1

[Kathleen :Brade]

m16

Comment 2

[Joe Francis]

i talked to sujay about this.  it isn't supposed to remove the link.  it just 
turns it off at the selection point.  

can we close this out?  I'd rather not have a bug like this unless we have a 
consensus decision to change the behavior.

Comment 3

[sujay]

so perhaps the issue is that we should disable the "Remove Link" menu
item when the link is not highlighted/selected?

Comment 4

[Kathleen :Brade]

reassign to cmanske so I don't step on his changes

Comment 5

[Charles Manske]

It probably should be disabled if selection is not in a link. Also:
When the caret is in a link or just at the end of one, I think the menu item
should be "End" or "Terminate Link", just as "Remove All Text Styles" should be
"End/Terminiate All Text Styles". As described, this should stop the link or
text attribute at the caret and wil affect text typed immedialely after using
the menu command.

Comment 6

[rubydoo123]

assign to me

Comment 7

[rubydoo123]

The action that results from selecting Remove Link is dependent on what is 
selected. If you have link text selected, and select Remove Link, then the 
anchor tag is removed. If you set the caret at a specific point within the link 
and select the Remove Link option, then it terminates the anchor tag and you're 
allowed to resume entering normal text. This behavior is consistent with other 
formatting elements such as bold and italic. The Remove Link option within the 
Format menu behaves consistently with the Remove All Styles option.

Renaming the option would also result in confusion, because if a link is 
selected it does remove the anchor tag. It would probably be better to add an 
additional menu item that terminated the link so normal text entry could resume. 

I'm going to later this to m20, mark it as an enhancement request.

Comment 8

[[e-mail]]

Thought: Create a toggle menu item Format/Linked which terminates or removes a
single existing link or creates a new link if the selection contains unlinked
(or multiply linked) text. Additionally toggle the toolbar button, in the same
vein as the existing style buttons.

Comment 9

[rubydoo123]

moving to future milestone

Comment 10

[Kathleen :Brade]

M18; correctness; nsbeta3; -> sfraser

Comment 11

[rubydoo123]

setting to nsbeta3+

Comment 12

[rubydoo123]

adding the brackets in the status

Comment 13

[rubydoo123]

setting priority in status whiteboard, trivial low risk

Comment 14

[rubydoo123]

i now understand the issues on this one, to remove the link, the link must be 
selected, what this option really does is terminate the link -- so marking this 
as wontfix

Comment 15

[sujay]

verified in 8/23 build.

Comment 16

[Simon Fraser [no longer active]]

Wait. This is not fixed.

Comment 17

[Simon Fraser [no longer active]]

We still need to disable the menu item when the selection is not in a link.

Comment 18

[rubydoo123]

oh ya -- putting it back on the + list

Comment 19

[Simon Fraser [no longer active]]

Per beppe, nsbeta3-

Comment 20

[rubydoo123]

moving to future per review with bij and beppe

Comment 21

[rubydoo123]

*** Bug 55082 has been marked as a duplicate of this bug. ***

Comment 22

[Charles Manske]

*** This bug has been marked as a duplicate of 68059 ***

Comment 23

[sujay]

verified.