29027 - Minimized not restored when called from Taskbar or Tasks menu.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[laurel]

Using 2000-02-23-08 commercial build NT 4.0
Using 2000-02-23-08 commercial build linux rh6.0

When mail window is minimized, selecting Tasks|Mail from Browser window or using
the mail icon on the task bar from browser will not restore the mail window. 
The reverse is also true for calling up the browser window from the mail window.

1.  You have one browser window open and one mail window open.
2.  Minimize the mail window.
3.  From the broswer window select Tasks|Mail.
    Result:  Nothing happens. Mail window is not restored, it stays in minimized
state.
4.  From browser window, click the mail/envelope icon on the task bar.
    Result:  Nothing happens. Mail window is not restored, it stays in minimized
state.

Expected result: mail window should restore and come to foreground.

Comment 1

[Phil Peterson]

I see the same behavior for other windows which are accessible from the Tasks
menu. So either the Tasks menu Javascript is wrong, or else the windowing
implementation is wrong. Starting with hangas.

Comment 2

[hangas]

After talking to danm, he felt he should have this bug.

Comment 3

[Peter Trudelle]

Mass-moving all M16 non-feature bugs to M17, which we now consider to be part 
of beta2.

Comment 4

[Peter Trudelle]

nominating for nsbeta2

Comment 5

[Peter Trudelle]

[nsbeta2+] will take fix by 6/1

Comment 6

[Peter Trudelle]

Mass-moving all dated nsbeta2+ bugs to M19

Comment 7

[Peter Trudelle]

freshness dating has expired, nominating for nsbeta3, moving to m21

Comment 8

[Brian Ryner (not reading)]

I'll take this bug.

Comment 9

[Brian Ryner (not reading)]

blizzard is working on a Linux fix for this.  A separate fix will be required 
for Windows, which I'm trying to figure out.

Comment 10

[Christopher Blizzard (:blizzard)]

Patch for Linux:

Index: nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk/nsWindow.cpp,v
retrieving revision 1.274
diff -u -r1.274 nsWindow.cpp
--- nsWindow.cpp        2000/06/07 00:11:46     1.274
+++ nsWindow.cpp        2000/06/08 20:22:03
@@ -912,7 +912,10 @@
if (top_mozarea)
{
if (!GTK_WIDGET_HAS_FOCUS(top_mozarea))
+    {
gtk_widget_grab_focus(top_mozarea);
+      GetAttention();
+    }
}

// check to see if we need to send a focus out event for the old window

Comment 11

[Brendan Eich [:brendan]]

If r=pavlov, a=brendan.

/be

Comment 12

[Christopher Blizzard (:blizzard)]

Fix checked in on Linux.

Comment 13

[leger]

Updating from [6/1] to [6/15]

Comment 14

[Brian Ryner (not reading)]

Fix is now checked in on Windows.  I'm going to find out what happens on Mac
before closing this bug.

Comment 15

[Brian Ryner (not reading)]

Per saari, we should not unshade a shaded window on Mac, so this is fine.

Comment 16

[laurel]

OK using:
2000-06-13-08 m17 commercial build linux rh6.0
2000-06-13-20 m17 commercial build NT 4.0