290683 - [Submission] Uploading XPI must require install.rdf

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Policy, defect)

Description

[Brian King [:kinger]]

When I try and upload an updated version of my extension (OpenKiosk), I get this
error:

Errors were encountered during install.rdf parsing...
Aborting...

This is a seamonkey only extension, and has no install.rdf.

Comment 1

[Brian King [:kinger]]

I'm presuming you are going to tell me that I'll need to package an install.rdf
with it?

Comment 2

[alanjstr]

Yep.  That's a good place to start.

Comment 3

[alanjstr]

*** Bug 290731 has been marked as a duplicate of this bug. ***

Comment 4

[alanjstr]

We need better instructions if install.rdf is not found.  It should also point
to http://kb.mozillazine.org/Install.rdf#Target_applications.27_GUIDs for more
information.  The patch for this bug should also remove the legacy handling for
Suite that would allow install.rdf to be missing (which currently seems broken)

Comment 5

[alanjstr]

Ok, to prevent future confusion, we should rip out the "legacy" support.  I've
been advocating it for months and now its gotten worse with Sunbird, Nvu,
Community Seamonkey, and Netscape.

So if you want your app to be listed on UMO, you'll need the right items in
install.rdf.

Comment 6

[Wolf [:wolf]]

Not even going to bother to look at what caused the bug described here?

Comment 7

[Brian King [:kinger]]

(In reply to comment #5)

> So if you want your app to be listed on UMO, you'll need the right items in
> install.rdf.

It should be documented somewhere what these items are. For example, for the
Mozilla Suite, you only need a bare bones version.
- application id and version
- target application info
- name
- creator

Anything else? 

Comment 8

[Brian King [:kinger]]

(In reply to comment #6)
> Not even going to bother to look at what caused the bug described here?

I think at least if a user tries to upload an extension without an install.rdf,
they should get a meaningful error message telling them so.

Comment 9

[Michael Morgan [:morgamic]]

Mass change - bugs to be read / (re)confirmed.

Comment 10

[Cameron]

AMO bugspam. Correcting QA contacts on OLD bugs ([e-mail])

-> Correct QA contact ([e-mail])

Filtermeplzkthx

Comment 11

[Justin Scott [:fligtar]]

In Remora (AMO v3), if there is no install.rdf present, an appropriate error is displayed. However, I think the second part of this bug is displaying somewhere what items are required in install.rdf for apps that don't normally use it.

Moving to policy for decision on where that should be displayed.

The properties additem requires for parsing are id, version, and target apps.

Comment 12

[Cameron]

I reckon just whack it on the error page when they're submitting:

"Even if your add-on is only aimed at applications which do not use install.rdf files (eg. Mozilla Suite, Seamonkey 1.0, etc.) we still require you to have a bare-bones install.rdf file for compatibility with the Mozilla Add-ons website. Your install.rdf must contain an em:id, an em:version and at least one em:targetApplication. See http://developer.mozilla.org/en/docs/install.rdf for more info."

Btw.. devmo says that em:name is required, otherwise it's not a valid install.rdf - we should probably make them include that too.

@fligtar: remember to adjust the QA contact :)

Comment 13

[Mike Shaver (:shaver emeritus)]

We should put this in the developer-guide-to-AMO, and link to the appropriate section of that guide from the error message.