290786 - [Submission] install.rdf parser doesn't give good error messages

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Description

[Geoff Smith]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050406 Firefox/1.0.2 StumbleUpon/1.9994 (Debian package 1.0.2-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050406 Firefox/1.0.2 StumbleUpon/1.9994 (Debian package 1.0.2-3)

When trying to upload a new version of StumbleUpon I get this:

Warning: Invalid argument supplied for foreach() in
/opt/update/developers/additem.php on line 107

Warning: Invalid argument supplied for foreach() in
/opt/update/developers/additem.php on line 107
ERROR!! This extension does NOT belong to the author logged in.
Terminating...


At least one other person has had this problem, reporting it in #UMO.

Reproducible: Always

Comment 1

[John Woods]

same here. Tried tonight, and it doesn't know I am supposed to be able to change
files here. So how to i get on the list of devs for that project. 

Comment 2

[alanjstr]

Well, it shouldn't be throwing a mySQL error, that's for sure.  

The registered email address for this extension is [e-mail].  Is
that the same as your dev account?

And once you can login, if it weren't broken, you can add additional authors.

Comment 3

[Colin Ogilvie [:cso]]

I think theres something slightly more subtle than what Alan suggests going on
here... more details whne I confirm them.

Comment 4

[Colin Ogilvie [:cso]]

On my development environment, $buf (the manifest file from the .xpi file) is
set to the contents of install.rdf.

$manifestdata, the parsed RDF file is just:

Array
(
    [targetApplication] => Array
        (
        )

)

This breaks the continued processing.

Confirming bug based on my development environment.

Comment 5

[alanjstr]

Geoff, can you provide a link to the XPI

Comment 6

[Geoff Smith]

http://www.stumbleupon.com/stumbleupon.xpi

version: 1.9994
size: 81K

Comment 7

[(not currently active) Ted Mielczarek]

Add
xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#" to the opening tag.  This is
not a valid RDF document otherwise, there's no default namespace.

I think this is INVALID.

Comment 8

[Geoff Smith]

Confirmed, stumbleupon RDF is invalid.

Copied from an invalid extension template, which suggests that other extensions
will have this problem.

Comment 9

[(not currently active) Ted Mielczarek]

morphing, patch coming up

Comment 10

[(not currently active) Ted Mielczarek]

Attachment: part 1: fix the parser to return null if there's nothing found

Fixes the parser half

Comment 11

[(not currently active) Ted Mielczarek]

the reason i said "part 1" is because i think a part 2 could involve a link to
docs somewhere (devmo?) explaining common install.rdf errors, including the one
in this example.

Comment 12

[Davide Ficano]

Attachment: This extension doesn't upload with NVU section

Comment 13

[(not currently active) Ted Mielczarek]

The install.rdf validates fine, I'll test it further when I get a chance.

Comment 14

[alanjstr]

I added Nvu, but the guid in some generated html is " 
{136c295a-4a5a-41cf-bf24-5cee526720d5}"

Update `applications` set `guid` = '{136c295a-4a5a-41cf-bf24-5cee526720d5}'
Where shortname = 'nv'

Fortunately, the GUID for Sunbird seems to be correct,
"{718e30fb-e89b-41dd-9da7-e25a45638b28}", so someone can try that.

Comment 15

[Colin Ogilvie [:cso]]

(In reply to comment #14)
> I added Nvu, but the guid in some generated html is " 
> {136c295a-4a5a-41cf-bf24-5cee526720d5}"
> 
> Update `applications` set `guid` = '{136c295a-4a5a-41cf-bf24-5cee526720d5}'
> Where shortname = 'nv'
> 
> Fortunately, the GUID for Sunbird seems to be correct,
> "{718e30fb-e89b-41dd-9da7-e25a45638b28}", so someone can try that.

You can actually just delete the version and re-add it which is what I did, and
it now works.

Alan's supicions were correct though, there was a tab or something in the field.

| {86c18b42-e466-45a9-ae7a-9b95ba6f5640}   | mz        | 1.7.7   |
|       {136c295a-4a5a-41cf-bf24-5cee526720d5} | nv        | 1.0B    |
| {718e30fb-e89b-41dd-9da7-e25a45638b28}   | sb        | 0.2     |
+------------------------------------------+-----------+---------+

Comment 16

[alanjstr]

We got hit by this again.  The problem is that we're not validating the RDF.  We
need to do that, and point them to http://kb.mozillazine.org/Install.rdf if an
error occurs.

Comment 17

[alanjstr]

*** Bug 291811 has been marked as a duplicate of this bug. ***

Comment 18

[alanjstr]

http://www.wiwiss.fu-berlin.de/suhl/bizer/rdfapi/
http://pear.php.net/package/RDF

Comment 19

[Colin Ogilvie [:cso]]

I don't see the need for RDF validation; we use an XML Parser, we can just get
the XML Parser error details and present that to the user. It may not be quite
as descriptive, but removes yet more external dependancies.

In the latest case the error would have been:

The Error was: Error at line 4, position 16. Erro string: unbound prefix

which would have helped I suspect.

Comment 20

[alanjstr]

*** Bug 292230 has been marked as a duplicate of this bug. ***

Comment 21

[Michael Morgan [:morgamic]]

Mass change - bugs to be read / (re)confirmed.

Comment 22

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

The error messages in this part of Remora are simply above reproach.