Closed Bug 291002 Opened 16 years ago Closed 15 years ago
Icons for Error Console buttons
6.85 KB, image/png
2.23 KB, image/png
5.43 KB, patch
|Details | Diff | Splinter Review|
36.90 KB, image/jpeg
25.38 KB, image/gif
Would it be possible to fix this as a polish bug maybe even after 1.5 beta? And maybe get the background color behind each entry (Message/Warning/Error) like on the Mac.
modified console.css new code for using the icons is att he very bottom, needs clean up a little since i'm not an css expert. Also I have no clue how to make diff files so if someone can explain I will be happy to do that and attach a patch. both of these files need to go in classic.jar in skin/classic/global/console/
Attachment #193481 - Attachment description: patch → winstripe patch
Attachment #193481 - Flags: review?(benjamin) → review?(kevin)
Comment on attachment 193486 [details] [diff] [review] pinstripe patch Please fix the "no newline at end of file"
Attachment #193486 - Flags: review?(benjamin) → review?(kevin)
this patch adds background color behind each entry (Message/Warning/Error) like on the Mac.
addresses Benjamin Smedberg's comment
addresses Benjamin Smedberg's comment sorry about all these edits...first time submitting patches.
Assignee: bugs → supernova_00
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 193564 [details] [diff] [review] winstripe patch 1.2 Kurt, Thanks for your work on this. I wish I'd seen this bug sooner though. I'm planning to do a makeover on the Winstripe JS console that hopefully will get in for 1.5, including icons with the Winstripe style. Can you please reassign to me? I'll use your winstripe patch as a starting point.
Attachment #193564 - Flags: review?(kevin) → review-
reassigned to email@example.com. no problem
Assignee: supernova_00 → kevin
OS: All → Windows XP
Hardware: All → PC
Kevin how is this looking for 1.5? If looks like it won't make 1.5, can we at least use my patches to make the console at least a little better looking and easier to view because of the background colors for different errors. No risk patch and no l10n affect so can be landed after 1.8b5.
(In reply to comment #16) > Created an attachment (id=198153)  > Here's a screenshot of the new graphics How come the small icons are missing the sign within?
(In reply to comment #17) > How come the small icons are missing the sign within? To reduce the visual weight of the bullet icons while stil providing a clue about the nature of the error. Also I didn't want to use the same icons in the toolbar and on the side because you don't interact with them the same way.
We could do something like this, which eliminates the row icon altogether. The downside is to get the color coded backgrounds we would have to hardcode both background and foreground colors.
Kevin, I think those icons plus the background colors would look great together...with just icons or just background color, the window seems like it's missing something. But with both, looks pretty darn good.
My 2 cents: I prefer the first screenshot presented by Kevin. Different background colors (rainbow) make it more difficult to get a good overview.
Colors are bad, just look at any remotely similar program, like the event viewer in Windows and imagine it with color marked lines and not just icons. Another question, what is the all button supposed to symbolize? I have tried to figure this one out, but nothing makes sense.
Just an idea of what the All icon could look like...
OK, here is the patch, without the color coded rows and with horizontal icons
Comment on attachment 200040 [details] [diff] [review] JS Console styles, second draft Beltzner has some suggested tweaks if you have more cycles, but this is good to go.
Attachment #200040 - Flags: review?(mconnor) → review+
*** Bug 266539 has been marked as a duplicate of this bug. ***
Hm. I'd originally been thinking that we'd use a right-align for the file name, then some padding and then a left-align for the number, so: [..........................................file.name] Line: [number] But to support that I guess we'd need code that truncates long labels (like in Windows Explorer or OS X Finder, so you'd get "reallyLongF...ame" and have a hover-help tip that contains the full filename) which would be more work than we have time for. Unless anyone can think of a way around this, then yeah, let's just strip the labels and keep current alignment for now. I'll be pouting in this corner over here ;)
final changes probably
Attachment #200160 - Flags: review?(mconnor)
Attachment #200160 - Flags: review?(mconnor) → review+
Comment on attachment 200160 [details] [diff] [review] round 3 of js console changes incorporating feedback low risk. good polish. requesting approval to land
Attachment #200160 - Flags: approval1.8rc1?
Comment on attachment 200160 [details] [diff] [review] round 3 of js console changes incorporating feedback Kevin, we won't have an opportunity to respin if this breaks anything. I'm approving so if you're confident in this, go ahead and land.
Attachment #200160 - Flags: approval1.8rc1? → approval1.8rc1+
Checked in to 1.8 branch. Thanks for the input everyone
The "Line x" text is not equally aligned for all rows. Also, the errors are not easy to read as before because of the bold text (my 2 cents)
This doesn't appear to be in trunk builds; is it going to be checked in?
(In reply to comment #38) > This doesn't appear to be in trunk builds; is it going to be checked in? bump
Kevin, can you check in whatever is needed on the trunk?
Gavin is there anything needed from this bug on the trunk that won't be covered by bug 345477? That bug seems to take over the purpose of this bug. I think the changes checked in from this bug were just to get something done for 1.5 with the hope that something better would be done in the future. The something better in terms of usability would be covered by Bug 312962.
(In reply to comment #41) > Gavin is there anything needed from this bug on the trunk that won't be covered > by bug 345477? I don't know what is going to be changed in bug 345477, so I can't really say.
Dupe of bug 345477 at this point?
Sure. *** This bug has been marked as a duplicate of 345477 ***
You need to log in before you can comment on or make changes to this bug.