29119 - Signature separator should be "-- "

Status: VERIFIED DUPLICATE of bug 35138

(MailNews Core :: Composition, defect, P3)

Description

[Akkana Peck]

In nsMsgCompose::ProcessSignature, the signature separator is listed as "--". 
It should be "-- " so that other mailers can strip out the signature when
generating replies.

Comment 1

[Jean-Francois Ducarroz]

for some reason, the extra space after the dashes has been removed. I am investigation why.

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=
mozilla/mailnews/compose/src&command=DIFF&root=/cvsroot&file=nsMsgCompose.cpp&rev1=1.117&rev2=1.118#5

Comment 2

[Akkana Peck]

Perhaps Rich can explain why he removed the space.

Comment 3

[rhp (gone)]

Sorry..didn't think the space was mandatory...

- rhp

Comment 4

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 5

[laurel]

This is apparently not fixed, evidenced by newly reported bug #35158. I'm going
to mark this duplicate of the new one.

Comment 6

[laurel]

*** This bug has been marked as a duplicate of 35138 ***

Comment 7

[laurel]

verified as a duplicate.

Comment 8

[Gwyn Judd]

Huh? How is bug 35158 (drop down menus not working) related in any way to this
one? Am I dense?

Comment 9

[laurel]

I made a typo in the bug number, OK?  The right bug number was already
referenced in the previous comments, so I decided not to create a bunch of new 
emails to everyone for something that was easily trackable.

Thank you for caring.  You're right, it's a duplicate of bug #35158.

Comment 10

[esther]

Using build 2001-09-04 on win, mac and linux and using a created signature with 
"-- " (minus the quotes) as the first line, this is fixed.  When viewing the 
composed msg and receiving it, we don't add another "-- " to the signature.  
Verified.