35158 - Sig delimiter malformed

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Ben Bucksch (:BenB)]

"--" is inserted as sig delimiter, not "-- ". This is a violation of
son-of-1036.

I have a fix for this. Per Daniel's request (which is a good idea in general, I
think), I'm also wrapping sigs (both plain text and HTML) in a <div
class=signature>. I'll attach a patch. Rich, can you review/check in please?

Comment 1

[Ben Bucksch (:BenB)]

After the tree reopened, of course.

Comment 2

[Ben Bucksch (:BenB)]

Attachment: |cd mailnews/compose; POSIXLY_CORRECT=1 cvs -Q diff -p .|

Comment 3

[Ben Bucksch (:BenB)]

BTW: I just noticed, that there's "NS_MSG_MULTILINGUAL_SEND" twice now in
mailnews/compose/resources/locale/en-US/composeMsgs.properties; you gotta delete
one manually; sorry.

Apart from the above mentioned, I removed the IMO unnecessary inclusing of an
error notice in the msg, if you have an image signature and use the plain text
composer. That's why I touch 3 files instead of just nsMsgComposer.cpp.
I also use a temp string for the signature now, which might give a perf increase
for msgs with large quotes.

Comment 4

[Gervase Markham [:gerv]]

Ben B - what's the score with this bug? Your last message is inconclusive - have 
you fixed it?

Gerv

Comment 5

[Ben Bucksch (:BenB)]

Yes, it is fixed, just not checked in. The two "NS_MSG_MULTILINGUAL_SEND"s were
just a stupid mistake in the patch, which can be easily manually fixed as
described. This patch really should be checked in for M16. rhp?

Comment 6

[Gervase Markham [:gerv]]

[e-mail] - could you have a look at this bug, please? I think Ben is 
asking you to check the patch in...

Gerv

Comment 7

[rhp (gone)]

Everything looks fine from a visual review, but I haven't run or test the patch 
so I am assuming that its fine with respect to that.

- rhp

Comment 8

[leger]

Putting on [nsbeta2-] radar for commericial.  But happy to take patch via 
mozilla.

Comment 9

[Gervase Markham [:gerv]]

Ben - who shall we try and persuade to check this in? :-)

Gerv

Comment 10

[rhp (gone)]

It will get checked in shortly after we have the M16 bits declared "complete". 
These changes are in my tree and I will be reviewing them and checking them in 
for all platforms soon.

- rhp

Comment 11

[Ben Bucksch (:BenB)]

Fix checked in by rhp.

Comment 12

[esther]

Using build 2001-09-04 on win, mac and linux and using a created signature with 
"-- " (minus the quotes) as the first line, this is fixed.  When viewing the 
composed msg and receiving it, we don't add another "-- " to the signature.  
Verified.