291265 - strict javascript warnings in findbar.js

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Henrik Gemal]

I'm seeing a lot of strict javascript warnings in findbar.js. They polute my
JavaScript console making it harder to find other warnings.

Warning: function flashFindBar does not always return a value
Source File: chrome://global/content/findBar.js
Line: 496
Source Code:
}

Warning: function onFindAgainCmd does not always return a value
Source File: chrome://global/content/findBar.js
Line: 530
Source Code:
}

Warning: function onFindPreviousCmd does not always return a value
Source File: chrome://global/content/findBar.js
Line: 549
Source Code:
}

Comment 1

[Daniel C]

There's also:

Error: document.commandDispatcher.focusedElement.parentNode has no properties
Source File: chrome://global/content/findBar.js
Line: 289

as mentioned in bug 286885 and bug 273910.

Comment 2

[Jason Barnabe (np)]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 181675 [details] [diff] [review]
patch

Looks fine to me, but I'm not a browser peer and therefore can't review. Feel
free to CC me on any other strict warning bugs, though. Also, in the future,
could you diff from the root of the tree? It makes it easier to apply the
patches.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Updated patch

Jason, I've updated your patch against the actual head and with the notes given
from Gavin. Hope that's ok for you. I will see that bug fixed hopefully soon.

Comment 5

[timeless]

Comment on attachment 185365 [details] [diff] [review]
Updated patch

mozilla/toolkit/components/typeaheadfind/content/findBar.js	1.11