switching from drafts folder to saved search folder does not remove "Edit Draft..." button

RESOLVED FIXED in Thunderbird2.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Daniel Steinbrook, Assigned: Scott MacGregor)

Tracking

({fixed1.8.1.1})

unspecified
Thunderbird2.0
x86
Windows XP
fixed1.8.1.1
Bug Flags:
blocking-thunderbird2 -
blocking1.8.0.5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050418 Thunderbird/1.0.2

When switching folders in the folder pane from the Drafts folder to a saved
search folder, the "Edit Draft..." button next to the message headers doesn't
disappear for messages not located in the Drafts folder as it should.

Reproducible: Always

Steps to Reproduce:
1. Open the Drafts folder, and click on a message.
2. Using the folder pane, switch to a saved search folder, and click on a message. 
Actual Results:  
Even if the message is not a draft, the "Edit Draft..." button is still there.

Expected Results:  
The "Edit Draft..." button should disappear for messages that are not drafts.

Comment 1

13 years ago
Confirming.

Precise behavior slightly more complicated ... "edit draft" sticks if the first
message clicked is a draft.  But if first message clicked is not a draft and
later you click a draft, then "edit draft" does not appear as it should.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

13 years ago
clarification (In reply to comment #1)
> if first message clicked is not a draft and later you click a draft 

... inside the saved search

> then "edit draft" does not appear as it should.

Comment 3

13 years ago
I can confirm this.

You might be right on this, however, I find it very annoying that when I save a
message to the draft folder on an IMAP-server (Cyrus) I get a message in the
system tray (WinXP) that I have a new unread message.

I have looked for a bug report about this but haven't found any, should I enter
a new bug about this?

Updated

12 years ago
Flags: blocking1.8.0.5?
(Assignee)

Comment 4

12 years ago
I don't think this is really a security issue or an issue that would warrant investigation for the 1.8.0.x branch.
Flags: blocking1.8.0.5? → blocking1.8.0.5-

Comment 5

12 years ago
Scott, OK. Trying to block thunderbird 2.0 then :-p
Flags: blocking-thunderbird2?
(Assignee)

Comment 6

11 years ago
not a stop ship, but I'm going to put it in the thunderbird 2 bug bucket.
Flags: blocking-thunderbird2? → blocking-thunderbird2-
Target Milestone: --- → Thunderbird2.0
(Assignee)

Comment 7

11 years ago
I think this is happening because gIsEditableMsgFolder gets set in OnItemEvent when the eventType == folderLoaded. 

When we load a saved search folder, I don't think this gets called so gIsEditableMsgFolder never gets cleared.
(Assignee)

Comment 8

11 years ago
Created attachment 247760 [details] [diff] [review]
the fix

David, what do you think of this solution? Instead of using a global variable that gets set when we load a folder, check the folder of the message we are in the process of laying out. Checking on a per message basis has the added benefit of making the Edit Draft button work for messages in saved search folders whose real parent folder is a Draft folder.
Attachment #247760 - Flags: superreview?(bienvenu)

Comment 9

11 years ago
Comment on attachment 247760 [details] [diff] [review]
the fix

+    return; // no msgHdr to add our tags to


this comment looks cloned :-) Otherwise, this seems fine.
Attachment #247760 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 10

11 years ago
fixed branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Depends on: 375381
You need to log in before you can comment on or make changes to this bug.