User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050418 Thunderbird/1.0.2 When switching folders in the folder pane from the Drafts folder to a saved search folder, the "Edit Draft..." button next to the message headers doesn't disappear for messages not located in the Drafts folder as it should. Reproducible: Always Steps to Reproduce: 1. Open the Drafts folder, and click on a message. 2. Using the folder pane, switch to a saved search folder, and click on a message. Actual Results: Even if the message is not a draft, the "Edit Draft..." button is still there. Expected Results: The "Edit Draft..." button should disappear for messages that are not drafts.
Confirming. Precise behavior slightly more complicated ... "edit draft" sticks if the first message clicked is a draft. But if first message clicked is not a draft and later you click a draft, then "edit draft" does not appear as it should.
clarification (In reply to comment #1) > if first message clicked is not a draft and later you click a draft ... inside the saved search > then "edit draft" does not appear as it should.
I can confirm this. You might be right on this, however, I find it very annoying that when I save a message to the draft folder on an IMAP-server (Cyrus) I get a message in the system tray (WinXP) that I have a new unread message. I have looked for a bug report about this but haven't found any, should I enter a new bug about this?
I don't think this is really a security issue or an issue that would warrant investigation for the 1.8.0.x branch.
Scott, OK. Trying to block thunderbird 2.0 then :-p
not a stop ship, but I'm going to put it in the thunderbird 2 bug bucket.
I think this is happening because gIsEditableMsgFolder gets set in OnItemEvent when the eventType == folderLoaded. When we load a saved search folder, I don't think this gets called so gIsEditableMsgFolder never gets cleared.
Created attachment 247760 [details] [diff] [review] the fix David, what do you think of this solution? Instead of using a global variable that gets set when we load a folder, check the folder of the message we are in the process of laying out. Checking on a per message basis has the added benefit of making the Edit Draft button work for messages in saved search folders whose real parent folder is a Draft folder.
Comment on attachment 247760 [details] [diff] [review] the fix + return; // no msgHdr to add our tags to this comment looks cloned :-) Otherwise, this seems fine.
fixed branch and trunk.