29138 - illegal usage of nsString- convert file name in char* to PRUnichar* without correct conversion

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Frank Tang]

Here is the stack trace

nsString::Append(const char * 0x0012f1cc, int 0x00000012) line 1108 + 43 bytes
nsFileWidget::Show() line 176
nsFileControlFrame::MouseClick(nsIDOMEvent * 0x02ea5284) line 256 + 11 bytes
nsEventListenerManager::HandleEvent(nsIPresContext * 0x02ed3480, nsEvent *
0x0012f678, nsIDOMEvent * * 0x0012f5e4, unsigned int 0x00000007, nsEventStatus *
0x0012f9cc) line 767 + 17 bytes
nsGenericElement::HandleDOMEvent(nsIPresContext * 0x02ed3480, nsEvent *
0x0012f678, nsIDOMEvent * * 0x0012f5e4, unsigned int 0x00000001, nsEventStatus *
0x0012f9cc) line 1010
nsHTMLInputElement::HandleDOMEvent(nsHTMLInputElement * const 0x02bfe6d0,
nsIPresContext * 0x02ed3480, nsEvent * 0x0012f678, nsIDOMEvent * * 0x00000000,
unsigned int 0x00000001, nsEventStatus * 0x0012f9cc) line 812 + 31 bytes
nsEventStateManager::CheckForAndDispatchClick(nsEventStateManager * const
0x02b6dd40, nsIPresContext * 0x02ed3480, nsMouseEvent * 0x0012fac0,
nsEventStatus * 0x0012f9cc) line 1670 + 42 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x02b6dd40,
nsIPresContext * 0x02ed3480, nsGUIEvent * 0x0012fac0, nsIFrame * 0x021b81b8,
nsEventStatus * 0x0012f9cc, nsIView * 0x02b73520) line 856 + 24 bytes
PresShell::HandleEvent(PresShell * const 0x02b53b64, nsIView * 0x02b73520,
nsGUIEvent * 0x0012fac0, nsEventStatus * 0x0012f9cc) line 2955 + 43 bytes
nsView::HandleEvent(nsView * const 0x02b73520, nsGUIEvent * 0x0012fac0, unsigned
int 0x00000008, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 799
nsView::HandleEvent(nsView * const 0x02b73c20, nsGUIEvent * 0x0012fac0, unsigned
int 0x00000008, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 784
nsView::HandleEvent(nsView * const 0x02b52070, nsGUIEvent * 0x0012fac0, unsigned
int 0x0000001c, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 784
nsViewManager2::DispatchEvent(nsViewManager2 * const 0x02b522f0, nsGUIEvent *
0x0012fac0, nsEventStatus * 0x0012f9cc) line 1216
HandleEvent(nsGUIEvent * 0x0012fac0) line 69
nsWindow::DispatchEvent(nsWindow * const 0x02b73b04, nsGUIEvent * 0x0012fac0,
nsEventStatus & nsEventStatus_eIgnore) line 493 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012fac0) line 514
nsWindow::DispatchMouseEvent(unsigned int 0x0000012d, nsPoint * 0x00000000) line
2938 + 21 bytes

Here is the code mozilla/widget/src/windows/nsFileWidget.cpp
102 PRBool nsFileWidget::Show()
...

171 nhotta 3.30 // I think it also needs a conversion here (to unicode since
appending to nsString)
172 // but doing that generates garbage file name, weird.
173 kipp 1.1 mFile.Append(fileBuffer);
174 }
175

notice that nhotta mention this should be convert
The data in the

Comment 1

[Peter Trudelle]

reassigning to danm

Comment 2

[Frank Tang]

This is one of the cause of 29062 and it caught when I apply the assertion patch
stated in 28424 to locate the problematic code.
As nhotta said, if we apply unicode conversion here right now, it will cause
wrong result. The reason is because of another bug 29145. Therefore, these two
bug have to be fix in the same time.

Comment 3

[Frank Tang]

mistakely put 19145 as dependency. Remove it.

Comment 4

[Frank Tang]

This bug does not block 29062. I just caught this when I try to fix 29062.
Remove the dep

Comment 5

[Paul MacQuiddy]

*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
[e-mail]

Comment 6

[Frank Tang]

danm, this bug is in the NEW state for almost 20 days. Can you confirm that you 
will work on it ?

Comment 7

[Peter Trudelle]

reassigning to pinkerton as p3 for m15

Comment 8

[Mike Pinkerton (not reading bugmail)]

accepting.

Comment 9

[Mike Pinkerton (not reading bugmail)]

moving all defects not directly related to P0 beta2 features off to M18.

Comment 10

[Peter Trudelle]

Back to danm, who has the related bug 29145.  If anyone needs this for beta2, 
please speak up now.

Comment 11

[Peter Trudelle]

Mass moving M18 bugs to M19

Comment 12

[Peter Trudelle]

mass-moving all bugs to m21 that are not dogfood+ or nsbeta2+ or nsbeta2-

Comment 13

[bobj]

added intl keyword

Comment 14

[Makoto Kato [:m_kato]]

This was already fixed at past.  We should mark as WFM.