29145 - illegal use of nsString::ToNewCString

Status: RESOLVED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Frank Tang]

Here is the stack trace.
sString::ToCString(char * 0x02ea38e8, unsigned int 0x00000013, unsigned int
0x00000000) line 805
nsSimpleCharString::operator=(const nsString & {...}) line 120
nsSimpleCharString::nsSimpleCharString(const nsString & {...}) line 76
nsFilePath::nsFilePath(const nsString & {...}, int 0x00000000) line 698 + 23 bytes
nsFileWidget::GetFile(nsFileWidget * const 0x02ea56c0, nsFileSpec & {...}) line 228
nsFileControlFrame::MouseClick(nsIDOMEvent * 0x02ea5284) line 261
nsEventListenerManager::HandleEvent(nsIPresContext * 0x02ed3480, nsEvent *
0x0012f678, nsIDOMEvent * * 0x0012f5e4, unsigned int 0x00000007, nsEventStatus *
0x0012f9cc) line 767 + 17 bytes
nsGenericElement::HandleDOMEvent(nsIPresContext * 0x02ed3480, nsEvent *
0x0012f678, nsIDOMEvent * * 0x0012f5e4, unsigned int 0x00000001, nsEventStatus *
0x0012f9cc) line 1010
nsHTMLInputElement::HandleDOMEvent(nsHTMLInputElement * const 0x02bfe6d0,
nsIPresContext * 0x02ed3480, nsEvent * 0x0012f678, nsIDOMEvent * * 0x00000000,
unsigned int 0x00000001, nsEventStatus * 0x0012f9cc) line 812 + 31 bytes
nsEventStateManager::CheckForAndDispatchClick(nsEventStateManager * const
0x02b6dd40, nsIPresContext * 0x02ed3480, nsMouseEvent * 0x0012fac0,
nsEventStatus * 0x0012f9cc) line 1670 + 42 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x02b6dd40,
nsIPresContext * 0x02ed3480, nsGUIEvent * 0x0012fac0, nsIFrame * 0x021b81b8,
nsEventStatus * 0x0012f9cc, nsIView * 0x02b73520) line 856 + 24 bytes
PresShell::HandleEvent(PresShell * const 0x02b53b64, nsIView * 0x02b73520,
nsGUIEvent * 0x0012fac0, nsEventStatus * 0x0012f9cc) line 2955 + 43 bytes
nsView::HandleEvent(nsView * const 0x02b73520, nsGUIEvent * 0x0012fac0, unsigned
int 0x00000008, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 799
nsView::HandleEvent(nsView * const 0x02b73c20, nsGUIEvent * 0x0012fac0, unsigned
int 0x00000008, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 784
nsView::HandleEvent(nsView * const 0x02b52070, nsGUIEvent * 0x0012fac0, unsigned
int 0x0000001c, nsEventStatus * 0x0012f9cc, int & 0x00000000) line 784
nsViewManager2::DispatchEvent(nsViewManager2 * const 0x02b522f0, nsGUIEvent *
0x0012fac0, nsEventStatus * 0x0012f9cc) line 1216
HandleEvent(nsGUIEvent * 0x0012fac0) line 69
nsWindow::DispatchEvent(nsWindow * const 0x02b73b04, nsGUIEvent * 0x0012fac0,
nsEventStatus & nsEventStatus_eIgnore) line 493 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012fac0) line 514
nsWindow::DispatchMouseEvent(unsigned int 0x0000012d, nsPoint * 0x00000000) line
2938 + 21 bytes
ChildWindow::DispatchMouseEvent(unsigned int 0x0000012d, nsPoint * 0x00000000)
line 3156
nsWindow::ProcessMessage(unsigned int 0x00000202, unsigned int 0x00000000, long
0x019901c1, long * 0x0012fd58) line 2243 + 24 bytes

This is one of the cause of 29062 and it caught when I apply the assertion
patch stated in 28424 to locate the problematic code.
This is the cause why nhotta see wrong result when he try to do correct unicode
conversion for 29138. These two bugs have to be fix togetheter.

Comment 1

[Paul MacQuiddy]

*IGNORE* - massive spam changing open XPToolkit bug's QA contact to
[e-mail]

Comment 2

[Peter Trudelle]

Mass moving M18 bugs to M19

Comment 3

[Peter Trudelle]

mass-moving all bugs to m21 that are not dogfood+ or nsbeta2+ or nsbeta2-

Comment 4

[Dan M]

moving en masse all bugs that didn't get nsbeta3 nomination to "future" milestone

Comment 5

[Makoto Kato [:m_kato]]

Original code that uses nsFileSpec was already removed and are using unicode version of nsIFile now.  We should mark as WFM.