Closed Bug 291608 Opened 20 years ago Closed 20 years ago

Firefox ships 102 KB of unused EM images

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8final

People

(Reporter: me, Assigned: steffen.wilberg)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

unbitrotted again
8.66 KB, patch
kevin
: review+
asa
: approval-aviary1.1a1+
Details | Diff | Splinter Review 
The following 104KB of Extension Manager images continue to be packaged with
Winstripe despite the fact they are no longer in use:

viewWatermarkExtensions.png
viewWatermarkThemes.png
extensionAbout.png
extensionHome.png
extensionOptions.png
placeholder.gif (?)

There are related entries in extensions.css but they are either commented out of
select non-existant elements.
Or non-existent even.
Severity: normal → minor
This is not limited to Winstripe, see e.g.
http://lxr.mozilla.org/seamonkey/search?string=viewWatermarkExtensions.png
OS: Windows XP → All
Summary: Firefox ships 100KB of unused EM images in Winstripe → Firefox ships 100KB of unused EM images
Attached patch patch (obsolete) — — Splinter Review 
I didn't test the patch yet because the EM is completely broken for me right
now.

The large images are viewWatermarkExtensions.png and viewWatermarkThemes.png,
which were used for the background. The ".extension-button" classes refer to
the small options/about/homepage buttons for each extension, which were removed
quite a long time ago.

These files can be cvs removed after applying the patch:
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionOptions.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png

mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png

mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png

mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png

mozilla/toolkit/themes/qute/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/qute/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/qute/mozapps/extensions/extensionOptions.png
mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif
mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png
mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png
Assignee: bugs → steffen.wilberg
Status: NEW → ASSIGNED
Different from Winstripe and Qute, Pinstripe uses extensionOptions.png in a
second place, so it can't be removed:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#103
Severity: minor → normal
Hardware: PC → All
Target Milestone: --- → Firefox1.1
Might make sense to take care of bug 292592 here?

Btw the EM works fine now.
Comment on attachment 181659 [details] [diff] [review]
patch

Works fine in both Firefox and Thunderbird. Tested on Linux.
Attachment #181659 - Attachment description: untested patch → patch
Attachment #181659 - Flags: review?(mconnor)
Attached patch unbitrotted patch (obsolete) — — Splinter Review 
Bug 258650 did some of the work, but not all of it.
Attachment #181659 - Attachment is obsolete: true
Attachment #184032 - Flags: review?(kevin)
Attachment #181659 - Flags: review?(mconnor)

        Attachment #184032 -
        Attachment is obsolete: true

        Attachment #184243 -
        Flags: review?(kevin)

    
  

        Attachment #184032 -
        Flags: review?(kevin)

    
  

        Attachment #184243 -
        Flags: review?(kevin) → review+

    
  

        Attachment #184243 -
        Flags: approval-aviary1.1a1?

    
    

    
  
Comment on attachment 184243 [details] [diff] [review]
unbitrotted again

a=asa

        Attachment #184243 -
        Flags: approval-aviary1.1a1? → approval-aviary1.1a1+

    
    

    
  
For the record, viewWatermarkExtensions.png had 47k, viewWatermarkThemes.png had
55k.

Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.11; previous revision: 1.10
done
Checking in mozilla/toolkit/themes/winstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/toolkit/themes/pinstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css,v  <-- 
extensions.css
new revision: 1.11; previous revision: 1.10
done
Checking in mozilla/toolkit/themes/qute/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done
Summary: Firefox ships 100KB of unused EM images → Firefox ships 102 KB of unused EM images

    
    

    
  
Removing
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif,v  <-- 
placeholder.gif
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif,v 
<--  placeholder.gif
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done

Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: