291608 - Firefox ships 102 KB of unused EM images

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[PikeUK]

The following 104KB of Extension Manager images continue to be packaged with
Winstripe despite the fact they are no longer in use:

viewWatermarkExtensions.png
viewWatermarkThemes.png
extensionAbout.png
extensionHome.png
extensionOptions.png
placeholder.gif (?)

There are related entries in extensions.css but they are either commented out of
select non-existant elements.

Comment 1

[PikeUK]

Or non-existent even.

Comment 2

[Steffen Wilberg]

This is not limited to Winstripe, see e.g.
http://lxr.mozilla.org/seamonkey/search?string=viewWatermarkExtensions.png

Comment 3

[Steffen Wilberg]

Attachment: patch

I didn't test the patch yet because the EM is completely broken for me right
now.

The large images are viewWatermarkExtensions.png and viewWatermarkThemes.png,
which were used for the background. The ".extension-button" classes refer to
the small options/about/homepage buttons for each extension, which were removed
quite a long time ago.

These files can be cvs removed after applying the patch:
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensionOptions.png
mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png

mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png

mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png

mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png

mozilla/toolkit/themes/qute/mozapps/extensions/extensionAbout.png
mozilla/toolkit/themes/qute/mozapps/extensions/extensionHome.png
mozilla/toolkit/themes/qute/mozapps/extensions/extensionOptions.png
mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif
mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png
mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png

Comment 4

[Steffen Wilberg]

Different from Winstripe and Qute, Pinstripe uses extensionOptions.png in a
second place, so it can't be removed:
http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/extensions/extensions.css#103

Comment 5

[Nickolay_Ponomarev]

Might make sense to take care of bug 292592 here?

Btw the EM works fine now.

Comment 6

[Steffen Wilberg]

Comment on attachment 181659 [details] [diff] [review]
patch

Works fine in both Firefox and Thunderbird. Tested on Linux.

Comment 7

[Steffen Wilberg]

Attachment: unbitrotted patch

Bug 258650 did some of the work, but not all of it.

Comment 8

[Steffen Wilberg]

Attachment: unbitrotted again

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 184243 [details] [diff] [review]
unbitrotted again

a=asa

Comment 10

[Steffen Wilberg]

For the record, viewWatermarkExtensions.png had 47k, viewWatermarkThemes.png had
55k.

Checking in mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v 
<--  extensions.css
new revision: 1.11; previous revision: 1.10
done
Checking in mozilla/toolkit/themes/winstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/toolkit/themes/pinstripe/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.5; previous revision: 1.4
done
Checking in mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/extensions.css,v  <-- 
extensions.css
new revision: 1.11; previous revision: 1.10
done
Checking in mozilla/toolkit/themes/qute/mozapps/jar.mn;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/jar.mn,v  <--  jar.mn
new revision: 1.6; previous revision: 1.5
done

Comment 11

[Steffen Wilberg]

Removing
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/placeholder.gif,v  <-- 
placeholder.gif
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/qute/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done
Removing mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/placeholder.gif,v 
<--  placeholder.gif
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkExtensions.png,v
 <--  viewWatermarkExtensions.png
new revision: delete; previous revision: 1.2
done
Removing
mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/viewWatermarkThemes.png,v
 <--  viewWatermarkThemes.png
new revision: delete; previous revision: 1.2
done