292619 - to-be-installed extension disappears from EM during incompatible update check

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

When installing an extension that has a maxVersion lower than the
app.extensions.version pref the EM will phone home to check if the maxVersion
has been bumped to a compatible version. When this occurs the extension is
removed from the ui which can be confusing to the user.

Instead the ui should either continue displaying the extension and only remove
it after the phone home has completed if it is still incompatible or better
still it could update the display to show the user that it is checking for a
compatible version, etc.

Comment 1

[Caleb]

I confirm this.

It seems that if you try to install a very very old extension, the only thing
that you will hear is a beep, and the exntension won't even appear in the EM.

It should either show an alert saying that the extension is incompatible and not
install it, or show the alert and add it to the EM in the disabled mode/outdated
mode.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Checkpoint. This patch will need to wait on other patches waiting for the 1.1a
release to be checked in before it is reviewed but it does work as is.

Comment 3

[James Ross]

Seems like the EM actually fails because the item is removed, as far as I can
tell. Trying to install an incompatible extension logs this:

RDFItemUpdater:checkForUpdates sending a request to server for:
https://addons.mozilla.org/update/VersionCheck.php?reqVersion=1&id={59c81df5-4b7a-477b-912d-4e0fdf64e5f2}&version=0.9.67%2B&maxAppVersion=1.0&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=1.0%2B&appOS=WINNT,
item = ({id:"{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}", version:"0.9.67+",
installLocationKey:"app-profile", minAppVersion:"0.9", maxAppVersion:"1.0",
name:"ChatZilla", xpiURL:"", iconURL:"", updateRDF:"", type:2})

Error: subject has no properties
Source File:
file:///C:/Documents%20and%20Settings/James/My%20Documents/Mozilla.org/Development/tree-firefox-main/objdir/dist/bin/components/nsExtensionManager.js
Line: 3377

Comment 4

[Robert Strong (they/them - no direct email)]

The item is removed and the patch adds it back as an item being checked for an
incompatible update.

Thatt subject error from the js console is another aspect of bug 295847.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: better patch

This is pretty much completed but I want to wait on a couple of other patches
to land before requesting review.

Comment 6

[Worcester12345]

(In reply to comment #5)
> Created an attachment (id=185006) [edit]
> better patch
> 
> This is pretty much completed but I want to wait on a couple of other patches
> to land before requesting review.

Which other ones? Thanks.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin - this patch adds an item similar to a download when performing an
incompatible update with a description that reads "Firefox is checking for a
compatibility update to Extension_Name." with the same color text as an
incompatible item.

It also fixes:
1) a case where the install.rdf is left behind in the temp dir during an
incompatiblity update. It turns out it is lazily writing back to it when the
target app info is updated.
2) some context menu items are enabled for download items. This applied to the
new item as well so I took care of both of them at the same time.
3) buttons weren't properly updated when disabling an item.
4) a couple of really minor issues like calling this._inner.Flush(); instead of
this.Flush();, etc.

Comment 8

[timeless]

Comment on attachment 186397 [details] [diff] [review]
patch

mozilla/toolkit/mozapps/extensions/content/extensions.js	1.58
mozilla/toolkit/mozapps/extensions/content/extensions.xul	1.29
mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in 	1.119
mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css	1.9
mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css	1.12
mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties  
1.12