29271 - Need a warning dialog for non-matching charset in form posting

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Frank Tang]

If we type some text in form but the text cannot convert to the document 
charset, it will be nice we warn the user and provide the following information
1. It try to post as charset XXXX
2. The following field name YYY have text ZZZZ which cannot be represent as 
charset  XXXX and will be change to LLLL
3. Provide two choice- [Do not submit] [Submit it anyway]

Comment 1

[Frank Tang]

The concept is similar to 28908

Comment 2

[Frank Tang]

jbetak- you probably can help since you are now familar with the form posting 
code. Please look at how wallet and security code file prompt dialogbox at the 
form posting code. 

Comment 3

[[e-mail] (away - not reading bugmail)]

reassigning to ftang for resource reallocation

Comment 4

[Frank Tang]

mark assign.

Comment 5

[Frank Tang]

nhotta- can you teach me how to throw a warning dialog ?

Comment 6

[nhottanscp]

Mail code uses nsIPrompt::Confirm() for alert.
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgPrompts.cpp

Comment 7

[Vladimir Ermakov]

Updating QA contact.

Comment 8

[Frank Tang]

nhotta, can you add this ?
reassign browser related bug to nhotta.

Comment 9

[kill this account]

what will the data in question (ZZZZ) be converted to?

would it make sense to warn the user when they typed it in instead of when they
submitted it?

Comment 10

[Frank Tang]

mark it as Future

Comment 11

[Alexandru Savulov]

NAOKI:
  could you take a look at this one please?

I have bug 70838 assigned to me and that one has a miletone set.

If you cannot take care about this bug, go ahead and reassign it to me.

Thx!

Comment 12

[nhottanscp]

We need to check the error code NS_ERROR_UENC_NOMAPPING of
nsIUnicodeEncoder::Conver().
http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsFormSubmitter.cpp#1312

But I have no idea how to post alert in that code.
Alexandru, do you have any idea?

Comment 13

[nhottanscp]

cc to [e-mail], please see my last comment.

Comment 14

[Alexandru Savulov]

Naoki:
I'm looking at it. As soon as I have a wayto do that i'll let you know.

Comment 15

[Alexandru Savulov]

Naoki:

Unfortuantely the source code of nsFormSubmitter.cpp changed after j.keisers
checkin. However since then there is a piece of code that opens a notification
dialog. 

If that's what you need then loock in nsFormSubmitter::OnSubmit after

398 nsresult notifyStatus = formSubmitObserver->Notify(formElement,
399                                                    window,
400                                                    actionURL,
401                                                    &cancelSubmit);

Hope this helps!

Comment 16

[nhottanscp]

Okay, I will look intot this 0.9.8.

Comment 17

[R.K.Aa.]

*** Bug 189275 has been marked as a duplicate of this bug. ***

Comment 18

[bjoern]

are there any news on this? You said you'll look at it more than 2 years
ago ;-)

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.