293958 - "(100.0 * Number.MIN_VALUE).toPrecision (12);" fails

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Stephen Weeks]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1

The statement causes StringIndexOutOfBoundsException.

Reproducible: Always

Comment 1

[Attila Szegedi]

Attachment: Fix for the bug

I've fixed this -- I refactored the stripping of trailing zeroes into a
separate method, as it is performed from more than one place.

There are still some rough edges with my CVS access, so I can't commit this
myself at the moment.

Comment 2

[Attila Szegedi]

Any objections to me committing this?

Comment 3

[Igor Bukanov]

(In reply to comment #2)
> Any objections to me committing this?

Not an objection, but rather observation: the patch makes some cases where Rhino
currently hits the exception to go to infinite loop due to other bugs in DTOA
code. Fixing those bugs can trigger redesign of the whole code and in a longer
term the patch can be irrelevant.

Comment 4

[Attila Szegedi]

(In reply to comment #3)
> Not an objection, but rather observation: the patch makes some cases where 
Rhino
> currently hits the exception to go to infinite loop due to other bugs in DTOA
> code. Fixing those bugs can trigger redesign of the whole code and in a longer
> term the patch can be irrelevant.

Hm - I was unaware of these other bugs. Regardless, until those other bugs are 
fixed, the current patch would still improve the existing situation, wouldn't 
it? So the question is, do you see sense in committing this patch until the 
other bugs are tackled? (Your observation would suggest your opinion is that it 
does not, but you weren't explicit about it :-) )

Comment 5

[Attila Szegedi]

Attachment: A better fix for the bug

The original fix for the bug was itself buggy -- an occurrence of the "!="
operator should have been "==" instead :-[

Comment 6

[Igor Bukanov]

Reassigning to [e-mail] pending resolution of bug 288433

Comment 7

[Attila Szegedi]

Committed the fix to CVS.