293984 - Memory leak with adblock

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This seems to be suite-only.  Firefox doesn't leak.  Testcase is to create a
clean profile, install adblock in it, then run "mozilla about:blank" and
shutdown.  We rather leak the world (a docshell with everything that entrains,
plus things like nsContentPolicy, nsGenericFactory, fastload stuff, etc, etc).

I'll attach the leak log in a sec.

The fact that we leak nsContentPolicy makes me think we're basically leaking the
entire adblock JS component somehow...  So I figured it may be worth
investigating even if it's not happening in Firefox.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Mem leak log

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: balance tree for nsContentPolicy

Unfortunately, this tells me absolutely nothing.... :(	I'm also not sure
whence all the UNKNOWNs in there -- this is a debug unoptimized build....
visibility issues or something?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

running tools/rb/fix-linux-stack.pl over the balance tree might help

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fixed-up balance tree

Looks like we end up with one ref too many under
mozJSSubScriptLoader::LoadSubScript

Of course we also leak the mozJSSubScriptLoader, so perhaps I should be poking
at that instead...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Balance tree for subscript loader

This all looks like xpconnect fun....

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK, with a current trunk build this worksforme.  Possibly fixed by bug 300023.