294383 - Disable certain menu options (view source, find, text zoom, etc) when viewing non-text content (images, plugins)

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[Hermann Schwab]

Steps to repeat:
Use firefox 1.0.4 or a current trunk nightly, and load an image
Use Ctrl+U or menu View->PageSource or prepend view-source to the URL.

expected result: no source seen, or RFE: source seen as hex code
  actual result: bytes displayed as characters.

Bug seen in Firefox 1.0.4 and Firefox trunk, not seen in Mozilla Trunk.

gif : https://bugzilla.mozilla.org/mozilla-banner.gif
jpeg: http://ha.ckers.org/imagecrash.jpg
png : https://bugzilla.mozilla.org/attachment.cgi?id=183739


view-source:https://bugzilla.mozilla.org/mozilla-banner.gif
view-source:http://ha.ckers.org/imagecrash.jpg
view-source:https://bugzilla.mozilla.org/attachment.cgi?id=183739

Comment 1

[Hermann Schwab]

Mozilla Suite doesn´t show the source code on Ctrl+U or menu View->PageSource,
but shows it if the view-source: protocoll is used, like 
view-source:https://bugzilla.mozilla.org/mozilla-banner.gif

Firefox always shows the source.
I don´t mind the view-source: working, as that option is widely unknown.
The View->PageSource should be greyed out, and the Ctrl+U not working, as in
Mozilla Suite.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The suite disables more than just the "Page Source" option when viewing an
image, it disables a bunch of other menu items as well.

See the list at:
http://lxr.mozilla.org/mozilla/search?string=observes%3D%22isImage

I think it's worth investigating adding similar functionality to Firefox.

Comment 3

[Jason Barnabe (np)]

*** This bug has been marked as a duplicate of 206176 ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This bug is wider in scope, and is actually being worked on, so reopening and
marking depends.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch

This disables Find, View Source, Page Style, Text Zoom, and Character Set menu
options, as well as the View Source and View Selection source context menu
options.

This doesn't yet fix the This Frame -> View Source menu, that requires a few
bigger changes.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch (updated)

Updated to trunk. This is a port of the stuff from Seamonkey, and has been
tested to work with tabs, back/forward, etc.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: Patch v2

Without the unnecessary context menu changes.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/browser/base/content/browser-menubar.inc; new revision: 1.65
mozilla/browser/base/content/browser-sets.inc; new revision: 1.57
mozilla/browser/base/content/browser.js; new revision: 1.507

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Landed on the 1.8 branch for Firefox 2.
mozilla/browser/base/content/browser-menubar.inc;  new revision: 1.57.2.11;
mozilla/browser/base/content/browser-sets.inc;     new revision: 1.51.2.11;
mozilla/browser/base/content/browser.js;           new revision: 1.479.2.50;

Comment 10

[(no longer active)]

(In reply to comment #7)
> Created an attachment (id=187494) [details]
> Patch v2
> 
> Without the unnecessary context menu changes.

Why exclude the items in the context menu?  I think this leads to an inconsistent UI (for example, the user cannot view source from the View menu, but can do so from the context menu).

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> Why exclude the items in the context menu?  I think this leads to an
> inconsistent UI (for example, the user cannot view source from the View menu,
> but can do so from the context menu).

Please go ahead and file a bug if you think it's a problem, and CC me?

Comment 12

[(no longer active)]

(In reply to comment #11)
> Please go ahead and file a bug if you think it's a problem, and CC me?
> 

Done.  Bug 384854.