29459 - mouseover button causes reflow

Status: VERIFIED WORKSFORME

(Core :: Layout: Form Controls, defect, P1)

Description

[Andrew Niese]

Go to http://bonsai.mozilla.org/rview.cgi?cvsroot=/cvsroot&module=Raptor and 
hover over "Set Branch" button. This causes the "Menu" table to jolt to the 
left.

Is this neccessary?
Feb 27 2000 build.

Comment 1

[troy]

Changing component to Style System for unwanted reflow on mouse over

Comment 2

[Doron Rosenberg (IBM)]

Ok, I have a test case for this. Seems to be nested tables which cause this to
happen.  I am moving this to HTML Form Controls, which I think causes the bug.

Adding testcases after this message

Comment 3

[Doron Rosenberg (IBM)]

Attachment: This has the bug

Comment 4

[Doron Rosenberg (IBM)]

Attachment: Still has bug, one table killed.

Comment 5

[Doron Rosenberg (IBM)]

Attachment: outer table stripped, no bug

Comment 6

[karnaze (gone)]

Reassigning to Pierre based on Troy's assessment. Although a table change could 
probably fix the bug, we need to stop all of the unnecessary reflows.

Comment 7

[Marc Attinasi]

Assigning to Waqar: 1/3 of Pierre's NEW bugs to help reduce his doomage factor

Comment 8

[Pierre Saslawsky]

Reassigned back to me these bugs that shouldn't have left my list.

Comment 9

[waqar]

*** This bug has been marked as a duplicate of 29724 ***

Comment 10

[Andrew Niese]

actually, bug 29724 is a duplicate of THIS one, since I reported this 2 days 
earlier. this one also has better test cases, so I'm marking the other bug as a 
dupe.

Comment 11

[Andrew Niese]

*** Bug 29724 has been marked as a duplicate of this bug. ***

Comment 12

[Joseph Elwell]

I don't see how bug 29724 is a duplicate of this bug. In 29724 the page doesn't
shift or resize once. It duplicates A HREF tags! over and over again.

And the test case here is MUCH larger than the test case in bug 29724. So I
wouldn't call it better... :)

Comment 13

[Pierre Saslawsky]

I reopened bug 29724 because it doesn't describe just a reflow on mouseover. The 
links get duplicated too. I haven't seen that case in the other bug reports.

Comment 14

[Andrew Niese]

these are starting to sound like seperate issues, but maybe one will fix the 
other. sorry for the spam, in that case.

Comment 15

[rickg]

Mark, can you take a look into this one?

Comment 16

[Marc Attinasi]

Two cases from the test case from 02.28.00:

1) mouse over the button.
The text-alignment on the TextFrame inside of the GFXButtonControlFrame is 
changing, causing a REFLOW impact hint to be sent out of the Style System, 
causing the reflow. Put a breakpoint in StyleTextImpl::CalcDifference on the 
line that reads return NS_STYLE_HINT_REFLOW and mouse over the button.

2) Click into the edit control
This causes the whitespace text property to change for the BODY element's 
BlockFrame, causing the same REFLOW hint to come out of style. Put a breakpoint 
in StyleTextImpl::CalcDifference on the line that reads return 
NS_STYLE_HINT_REFLOW and click into the text edit control.

I'm not sure who these should go to, so I'm assigning to the component owner 
(the component looks correct).

Also, I'm assuming we all know that the reflow is a performance problem, but the 
table should layout the same after the reflow...

Comment 17

[rods (gone)]

Chris, we talked and you wanted me to assign this to you to look at. Changing to 
M16, P1, Major.

Comment 18

[ckritzer (gone)]

nominating for nsbeta2 based on:
 - severity
 - visibility
 - major functionality broken

Comment 19

[leger]

Putting on [nsbeta2-] radar. 

Comment 20

[leger]

Putting on nsbeta3 nomination per ckritzer request.

Comment 21

[karnaze (gone)]

Attachment: cleaned up minimal test

Comment 22

[karnaze (gone)]

Fixed.

Comment 23

[karnaze (gone)]

*** Bug 36384 has been marked as a duplicate of this bug. ***

Comment 24

[Pierre Saslawsky]

Reopening: the original testcase at the URL above (and only that testcase) fails 
when the GFX scrollbars are enabled. Tested with today's builds on Mac 
(2000.05.30.13) and Win98 (2000.05.30.08).

Comment 25

[Pierre Saslawsky]

Reassigned to evaughan because the remaining problem is related to gfx 
scrollbars.

Comment 26

[Eric Vaughan]

This works just fine for me with Gfx Scrollbars.

Comment 27

[bsharma]

Updating QA contact.

Comment 28

[WD]

Verified