294827 - "dialog has no properties" error in the JavaScript console after closing download attachment dialog

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Julien Lecomte]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

Open the JavaScript console, go to http://www.mozilla.org/, and click on 
the "Free Download" link (just an example...) A dialog is opened to ask you if 
you want to open or save the file. Just close the dialog using the "X" button. 
The error will appear 3 times in the JavaScript console.

Reproducible: Always

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050519
Firefox/1.0+ ID:2005051914

WFM (no errors)

Comment 2

[djpohly]

I can reproduce on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050519 Firefox/1.0+
if pref javascript.options.showInConsole is set to true.

Looks like some sort of bug in the Download Manager code.

Comment 3

[Ben Fowler]

Version 2006-05-17

I didn't see the error that you mentioned, but whilst following
your recipe, I got this ASSERTION:

    OnDataAvailable implementation consumed no data 

at http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsInputStreamPump.cpp#459

Comment 4

[Bob Cooley]

I can reproduce in 
Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.7) Gecko/20050414
Firefox/1.0.3

Occurs for open, save, or cancel.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same for Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050730
Firefox/1.0+

HW, OS => ALL

Comment 6

[Aaron Slunt]

I'm not seeing this in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4)
Gecko/20050810 Firefox/1.0+ ID:2005081004

Can anyone with linux still reproduce?

Comment 7

[Dorando]

Attachment: Checking if dialog exists before calling dialog.onBlur

This fixes it for me

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul;
new revision: 1.12;

Comment 9

[Mike Schroepfer]

Comment on attachment 192984 [details] [diff] [review]
Checking if dialog exists before calling dialog.onBlur

Per bug meeting - not approved for 1.8b5.

Comment 10

[Ben Fowler]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060316 Firefox/1.6a1

This dialogue does not have (or no longer has) a 'close button', but if comment 4
has full weight then 'Cancel' also reproduces the bug. There are currently no abnormal messages in the Javascript console, and given comment 7 and comment 8 ,
this bug is FIXED.

Note that when the "Opening ..." dialogue box is created, there is this message
in the log:

###!!! ASSERTION: If we have a txn pump, request must be it: '!mTransactionPump || request == mTransactionPump', file ../../../../../../src/netwerk/protocol/http/src/nsHttpChannel.cpp, line 4016