Closed
Bug 294984
Opened 20 years ago
Closed 20 years ago
Crash on data URI with unclosed iframe
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: mrbkap)
References
()
Details
Attachments
(1 file)
|
2.32 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
chofmann
:
approval1.8b2+
|
Details | Diff | Splinter Review |
The URL in the URL field crashes today's build quite reliably.
|
Assignee | |
Comment 1•20 years ago
|
||
I suck. There's an early return in ConsumeStartTag that doesn't enforce the
invarients that I try to.
Assignee: parser → mrbkap
Flags: blocking1.8b2?
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•20 years ago
|
||
The early return was causing us to not create the text token and end tag, so my
assumptions in CNavDTD were being violated. This patch fixes the early return.
Note that Consume[Parsed]CharacterData() is protected from this case and deals
properly.
Attachment #184145 -
Flags: superreview?(bzbarsky)
Attachment #184145 -
Flags: review?(bzbarsky)
|
Reporter | |
Updated•20 years ago
|
Attachment #184145 -
Flags: superreview?(bzbarsky)
Attachment #184145 -
Flags: superreview+
Attachment #184145 -
Flags: review?(bzbarsky)
Attachment #184145 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 184145 [details] [diff] [review]
patch v1
This fixes a recent crash regression.
Attachment #184145 -
Flags: approval1.8b2?
|
|
Assignee | |
Updated•20 years ago
|
Severity: normal → critical
OS: Linux → All
Hardware: PC → All
|
||
Comment 4•20 years ago
|
||
Comment on attachment 184145 [details] [diff] [review]
patch v1
a=chofmann
Attachment #184145 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Fix checked in. Sorry for the inconvenience.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•20 years ago
|
Flags: blocking1.8b2?
|
||
Updated•20 years ago
|
QA Contact: mrbkap → technutz
|
|
||
Comment 6•20 years ago
|
||
Verified FIXED with build 2005-05-22-06 on Windows XP Seamonkey trunk.
Testcase: data:text/html,<iframe
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•