32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.

RESOLVED FIXED in Camino1.5

Status

P4
trivial
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: moz, Assigned: jon)

Tracking

({fixed1.8.1, polish})

unspecified
Camino1.5
PowerPC
macOS
fixed1.8.1, polish

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

14 years ago
The 32x32 icons in fileHtml.icns and fileBookmark.icns have a wrongly-white
pixel in their upper right (right on the edge of the dog-ear). It's very
apparent when the icons are against a black background. Changing the pixel to
black and tweaking the alpha channel for that pixel to match another pixel on
the diagonal makes the pixel blend much more acceptably.
Wevah/Jasper, do you have fixed icons for this?  Perhaps they can land with the
fixed tab corner TIFFs in bug 298295?
Keywords: polish

Comment 2

14 years ago
I'll have a look at this. I think we don't even use fileBookark.icns maybe we
should remove it from the project? could save some space.

Updated

14 years ago
Priority: -- → P4
Target Milestone: --- → Camino1.2

Comment 3

14 years ago
Posted file Updated fileHtml.icns (obsolete) —
It appears that not only the 32x32 was jacked up but so was the 128x128.
Anyways this is updated without the white stuff

Comment 4

14 years ago
Again, removes whitespace from 32x32 and 128x128
(Reporter)

Comment 5

14 years ago
Erm, those both still have the bad white pixel in the 32x32 icon.

Comment 6

14 years ago
I will take a look at this tomorrow, should be really easy as I have the orginal
files.

Updated

14 years ago
Assignee: mikepinkerton → camino

Updated

14 years ago
Attachment #198872 - Attachment is obsolete: true

Updated

14 years ago
Attachment #198873 - Attachment is obsolete: true

Updated

14 years ago
Depends on: 312553
/me wonders when tomorrow will come. :-P
Removing dependency, since the other bug was WONTFIXed.
No longer depends on: 312553
Jasper: ping.  I bet this would be really fast and easy.  Do you think you could whip up a couple new icons here? :)

Updated

13 years ago
Summary: 32x32 versions of fileHtml.icns and fileBookmark.icns have a stray white pixel in the upper-right. → 32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.
Attachment #239173 - Flags: superreview?(mikepinkerton)
Attachment #239174 - Flags: superreview?(mikepinkerton)
Comment on attachment 239173 [details]
amended fileBookmark.icns file to remove stray pixel at 32px

rs=pink
Attachment #239173 - Flags: superreview?(mikepinkerton) → superreview+
Comment on attachment 239174 [details]
amended fileHtml.icns file to remove stray pixel at 32px

rs=pink
Attachment #239174 - Flags: superreview?(mikepinkerton) → superreview+
Assignee: camino → jon
Whiteboard: [needs checkin]
Target Milestone: Camino1.2 → Camino1.1
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: Camino1.1 → Camino1.2

Updated

13 years ago
Target Milestone: Camino1.2 → Camino1.1
You need to log in before you can comment on or make changes to this bug.