Closed
Bug 295165
Opened 20 years ago
Closed 18 years ago
32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.
Categories
(Camino Graveyard :: General, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: moz, Assigned: jon)
Details
(Keywords: fixed1.8.1, polish)
Attachments
(2 files, 2 obsolete files)
|
44.16 KB,
application/octet-stream
|
mikepinkerton
:
superreview+
|
Details |
|
43.41 KB,
application/octet-stream
|
mikepinkerton
:
superreview+
|
Details |
The 32x32 icons in fileHtml.icns and fileBookmark.icns have a wrongly-white
pixel in their upper right (right on the edge of the dog-ear). It's very
apparent when the icons are against a black background. Changing the pixel to
black and tweaking the alpha channel for that pixel to match another pixel on
the diagonal makes the pixel blend much more acceptably.
Wevah/Jasper, do you have fixed icons for this? Perhaps they can land with the
fixed tab corner TIFFs in bug 298295?
Keywords: polish
I'll have a look at this. I think we don't even use fileBookark.icns maybe we
should remove it from the project? could save some space.
|
||
Updated•19 years ago
|
Priority: -- → P4
Target Milestone: --- → Camino1.2
|
||
Comment 3•19 years ago
|
||
It appears that not only the 32x32 was jacked up but so was the 128x128.
Anyways this is updated without the white stuff
|
|
||
Comment 4•19 years ago
|
||
Again, removes whitespace from 32x32 and 128x128
|
Reporter | |
Comment 5•19 years ago
|
||
Erm, those both still have the bad white pixel in the 32x32 icon.
I will take a look at this tomorrow, should be really easy as I have the orginal
files.
Attachment #198872 -
Attachment is obsolete: true
Attachment #198873 -
Attachment is obsolete: true
|
||
Comment 7•19 years ago
|
||
/me wonders when tomorrow will come. :-P
|
||
Comment 8•18 years ago
|
||
Removing dependency, since the other bug was WONTFIXed.
No longer depends on: 312553
|
|
||
Comment 9•18 years ago
|
||
Jasper: ping. I bet this would be really fast and easy. Do you think you could whip up a couple new icons here? :)
|
|
||
Updated•18 years ago
|
Summary: 32x32 versions of fileHtml.icns and fileBookmark.icns have a stray white pixel in the upper-right. → 32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.
QA Contact: general
|
Assignee | |
Comment 10•18 years ago
|
||
|
|
Assignee | |
Comment 11•18 years ago
|
||
|
|
||
Updated•18 years ago
|
Attachment #239173 -
Flags: superreview?(mikepinkerton)
|
|
||
Updated•18 years ago
|
Attachment #239174 -
Flags: superreview?(mikepinkerton)
|
||
Comment 12•18 years ago
|
||
Comment on attachment 239173 [details]
amended fileBookmark.icns file to remove stray pixel at 32px
rs=pink
Attachment #239173 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
||
Comment 13•18 years ago
|
||
Comment on attachment 239174 [details]
amended fileHtml.icns file to remove stray pixel at 32px
rs=pink
Attachment #239174 -
Flags: superreview?(mikepinkerton) → superreview+
|
|
||
Updated•18 years ago
|
Assignee: camino → jon
Whiteboard: [needs checkin]
Target Milestone: Camino1.2 → Camino1.1
|
|
||
Comment 14•18 years ago
|
||
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: Camino1.1 → Camino1.2
|
|
||
Updated•18 years ago
|
Target Milestone: Camino1.2 → Camino1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•