Closed Bug 295165 Opened 19 years ago Closed 18 years ago

32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.

Categories

(Camino Graveyard :: General, defect, P4)

PowerPC
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: moz, Assigned: jon)

Details

(Keywords: fixed1.8.1, polish)

Attachments

(2 files, 2 obsolete files)

The 32x32 icons in fileHtml.icns and fileBookmark.icns have a wrongly-white
pixel in their upper right (right on the edge of the dog-ear). It's very
apparent when the icons are against a black background. Changing the pixel to
black and tweaking the alpha channel for that pixel to match another pixel on
the diagonal makes the pixel blend much more acceptably.
Wevah/Jasper, do you have fixed icons for this?  Perhaps they can land with the
fixed tab corner TIFFs in bug 298295?
Keywords: polish
I'll have a look at this. I think we don't even use fileBookark.icns maybe we
should remove it from the project? could save some space.
Priority: -- → P4
Target Milestone: --- → Camino1.2
Attached file Updated fileHtml.icns (obsolete) —
It appears that not only the 32x32 was jacked up but so was the 128x128.
Anyways this is updated without the white stuff
Again, removes whitespace from 32x32 and 128x128
Erm, those both still have the bad white pixel in the 32x32 icon.
I will take a look at this tomorrow, should be really easy as I have the orginal
files.
Assignee: mikepinkerton → camino
Attachment #198872 - Attachment is obsolete: true
Attachment #198873 - Attachment is obsolete: true
Depends on: 312553
/me wonders when tomorrow will come. :-P
Removing dependency, since the other bug was WONTFIXed.
No longer depends on: 312553
Jasper: ping.  I bet this would be really fast and easy.  Do you think you could whip up a couple new icons here? :)
Summary: 32x32 versions of fileHtml.icns and fileBookmark.icns have a stray white pixel in the upper-right. → 32x32 versions of fileHtml.icns and fileBookmark.icns (icons) have a stray white pixel in the upper-right.
Attachment #239173 - Flags: superreview?(mikepinkerton)
Attachment #239174 - Flags: superreview?(mikepinkerton)
Comment on attachment 239173 [details]
amended fileBookmark.icns file to remove stray pixel at 32px

rs=pink
Attachment #239173 - Flags: superreview?(mikepinkerton) → superreview+
Comment on attachment 239174 [details]
amended fileHtml.icns file to remove stray pixel at 32px

rs=pink
Attachment #239174 - Flags: superreview?(mikepinkerton) → superreview+
Assignee: camino → jon
Whiteboard: [needs checkin]
Target Milestone: Camino1.2 → Camino1.1
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Target Milestone: Camino1.1 → Camino1.2
Target Milestone: Camino1.2 → Camino1.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: