295237 - PrefWindowVs opened from Extension Manager lack pane switcher (toolbar)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Jesse Ruderman]

I tried to write an extension using PrefWindowV and couldn't get the pane
switcher to show up.  If I went to chrome://owo/content/owoOptions.xul in a
browser window, everything worked fine, but if I clicked the Options button in
the Extension Manager, all I could see was the first pane of my options window.

The Extension Manager's cmd_options at
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.js#806
does not include "toolbar" as a feature and 
http://lxr.mozilla.org/mozilla/source/toolkit/content/xul.css#998 makes the pane
switcher hidden in windows with chromehidden~="toolbar".

My first instinct is that cmd_options in the Extension Manager should be passing
",toolbar", but I wonder why xul.css specifically instructs preferences windows
to hide their panels when the "toolbar" feature isn't specified in the
openDialog call.

Comment 1

[Jesse Ruderman]

Nominating to block 1.1alpha.  If this isn't fixed in alpha, it will confuse
anyone who tries to make a PrefWindowV-using extension in alpha.  Furthermore,
when this is fixed, it may cause problems for extensions that expect the buggy
behavior.

Comment 2

[chris hofmann]

mconnor, smedberg,  any thoughts on a fix for this?

Comment 3

[Benjamin Smedberg]

See bug 283660, I think the correct solution is to just fix the EM to pass
"toolbar" in the open dialog.

Comment 4

[Asaf Romano (gone)]

Indeed. We should also respect the instantApply perf before adding the 'modal'
feature.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Asaf Romano (gone)]

Comment on attachment 184943 [details] [diff] [review]
patch


>+          var features = "chrome,titlebar,toolbar,centerscreen" + (instantApply ? ",dialog=no" : 
>+",modal");

gah, please ignore the new line here :-/

Comment 7

[Asaf Romano (gone)]

Attachment: add fallback...

Comment 8

[chris hofmann]

hoping there aren't too many extension builders out that that need to rely on
this fix to get pref windows straight. rafael can add to the release note this
to warn anyone who might be...  

b2 -> b3

Comment 9

[Dave Townsend [:mossop]]

If I read this right, if instantApply is true then the options opened from
extensions are non-modal, whether they are prefwindow based preferences or not.

So far as I can see there is currently nothing in place to then stop a user from
opening multiple copies of the extensions options.

Comment 10

[Asaf Romano (gone)]

Yeah, but there's not much we can do about it, at this point (fixing that would
requier at least one more install.rdf's entry)

(...I should also point out that w/o this change prefwindow-v based options
window are not closeable on os x.)

Comment 11

[chris hofmann]

Comment on attachment 184946 [details] [diff] [review]
add fallback...

a=chofmann

Comment 12

[Asaf Romano (gone)]

Checking in extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.54; previous revision: 1.53
done