295265 - Reintroduce chrome registry overrides

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Benjamin Smedberg]

In some cases it would be very useful for extension to "override" particular
chrome URIs in the core distribution with different versions. This was possible
in the old chrome registry through the use of an override JAR, but performance
was pretty bad.

This patch introduces a chrome manifest instruction:

override chrome://<package>/<provider>/<file-to-override[.js]> <override-URI>

Comment 1

[Darin Fisher]

Sounds like a great idea to me.  Given our extension versioning system, we ought
to be able to support extensions that dip into dark corners of the code using
this mechanism.

Comment 2

[Benjamin Smedberg]

Attachment: Add "override" instruction to chrome manifests, rev. 1

Comment 3

[Darin Fisher]

Comment on attachment 184340 [details] [diff] [review]
Add "override" instruction to chrome manifests, rev. 1

nicely done.  r=darin

Comment 4

[Benjamin Smedberg]

Comment on attachment 184340 [details] [diff] [review]
Add "override" instruction to chrome manifests, rev. 1

This is very low-risk and should be acceptable for 1.1a1 or a2.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 184340 [details] [diff] [review]
Add "override" instruction to chrome manifests, rev. 1

too late for a1

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184340 [details] [diff] [review]
Add "override" instruction to chrome manifests, rev. 1

a=shaver

Comment 7

[sairuh (rarely reading bugmail)]

could the fix here have caused bug 296376?

Comment 8

[sairuh (rarely reading bugmail)]

s/fix/check-in

Comment 9

[Benjamin Smedberg]

It's very unlikely.