295539 - Dialog boxes display with no text

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Dave Townsend [:mossop]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525 Firefox/1.0+

Recently on the trunk (over the last week maybe) every now and then I see
firefox display a dialog box with no text on the buttons, and sometimes no text
in the dialog itself. This is unfortunatly unreproducable but I have seen it in
various areas of the browser. Every time if I cancel the dialog and open it
again everything is fine.

I have two screenshots and errors from javascript console to follow. Also aside
from these two I also saw this when firefox asked me to set it as the default
browser.


Reproducible: Couldn't Reproduce

Steps to Reproduce:

Comment 1

[Dave Townsend [:mossop]]

Attachment: Shows an unknown security warning

This appeared when browsing away from a bugzilla bug to google (by typing into
the search bar). At first I thought it was the warning about leaving a https
page, but that warning only has 1 button so I don't really know what this is.

The following errors were in the javascript console:

Error: this.formatAccessKey is not a function
Source File: chrome://global/content/bindings/text.xml
Line: 71

Error: this._configureButtons is not a function
Source File: chrome://global/content/bindings/dialog.xml
Line: 118

Error: dialog.getButton is not a function
Source File: chrome://global/content/commonDialog.js
Line: 109

Comment 2

[Dave Townsend [:mossop]]

Attachment: Save As dialog with no button text

Shows the save as dialog as it appeared once. The following errors appeared:

Error: this._configureButtons is not a function
Source File: chrome://global/content/bindings/dialog.xml
Line: 118

Error: this.mDialog.document.documentElement.getButton is not a function
Source File: file:///C:/PROGRA~1/MOZILL~1/components/nsHelperAppDlg.js
Line: 385

The buttons were non-functional on this dialog, clicking them seemed to produce
this error:

Error: this.mDialog.document.documentElement.getButton is not a function
Source File: file:///C:/PROGRA~1/MOZILL~1/components/nsHelperAppDlg.js
Line: 478

Comment 3

[djpohly]

I can confirm Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050525 Firefox/1.0+

Comment 4

[Yani (fr)]

Attachment: Tools->Options Dialog Bugged

With some builds, "General" , "Privacy" , "Content" ,... are not even shown !

Comment 5

[Yani (fr)]

My current build is :
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050525
Firefox/1.0+  (bangbang023) ID:0000000000

Comment 6

[Yani (fr)]

A new clean profile resolved the problem.
Sorry,my bug has nothing to do with this one .

Comment 7

[Dave Townsend [:mossop]]

Attachment: Error trying to download extension update

This occured while trying to update an extension. Errors were:

Error: this._configureButtons is not a function
Source File: chrome://global/content/bindings/dialog.xml
Line: 118

Error: document.getElementById("brandStrings").getString is not a function
Source File: chrome://mozapps/content/update/errors.xul
Line: 27

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050527
Firefox/1.0+ ID:2005052712

Comment 8

[Robert Strong (they/them - no direct email)]

*** Bug 295575 has been marked as a duplicate of this bug. ***

Comment 9

[Caleb]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050602
Firefox/1.0+ ID:2005060208

I have not seen this :/

Comment 10

[Jason Daly]

Confirmed. DPA 1

Comment 11

[Jason Daly]

Attachment: error

error given when starting firefox. notice that there is no text in the dialog
box or the buttons.

Comment 12

[jsnod]

I have also seen this, in conjunction with Bug 296916.

Comment 13

[Robert Strong (they/them - no direct email)]

I've seen this in several different parts of the ui and when opening the same ui
a second time the problem disappears. This last time was when checking for
updates to an extension and the following errors were reported to the js console
appear to be related.

Warning: reference to undefined property this._initWizardButton
Source File: chrome://global/content/bindings/wizard.xml
Line: 166

Error: this._initWizardButton is not a function
Source File: chrome://global/content/bindings/wizard.xml
Line: 166

Comment 14

[Peter van der Woude [:Peter6]]

->major
with more exposure for 1.1a2 this is not what we want included.

Comment 15

[Bradley Chapman (not reading bugmail, still gone but not forever)]

This bug also affects the XPInstall dialog.

Comment 16

[Chris Beard]

we need steps to reproduce to verify that this is a problem, and if it is, we
should aim to get this fixed by 1.8b4

Comment 17

[Jason Daly]

Coming from a nightly, I experienced this when I installed dpa1. To fix the
problem I had to delete my profile and install a nightly. I'm not sure if
deleting the profile and then installing dpa1 would have solved the problem.

Comment 18

[Dave Townsend [:mossop]]

Attachment: Nasty testcase (read comment 18 first)

While experimenting with some javascript I managed to stumble upon a way to see
this issue consistently. Its a bit of a nasty hack though so make sure you
follow these steps, or you will end up having to kill the firefox process.

1. Make sure you have 2 firefox windows open (not tabs, windows) and that
javascript is enabled.
2. Open the test case in one.
3. The test case shows an alert dialog every 50ms, just hold down the enter
key.
4. After a while (no more than a minute for me), an alert dialog will show that
has no text and two blank buttons.
5. To stop this, go to the second firefox window, go into the options and
disable javascript.
6. Ok the alert and close the first window.

I could see the problem everytime with this method, except when I disabled the
adblock extension.

Comment 19

[djpohly]

Attachment: less evil testcase

I couldn't get the previous testcase to work, but this one might be a little
friendlier.  Set something heavy on the Enter key as directed above, or click
Cancel to stop the insanity.

Comment 20

[Dave Townsend [:mossop]]

The new testcase does cause the problem for me, though it is slightly different.
With my test case, when the problem happens the dialog has no text inside it and
a number of errors appear in the javascript console:

Error: this.formatAccessKey is not a function
Source File: chrome://global/content/bindings/text.xml
Line: 71
Error: this._configureButtons is not a function
Source File: chrome://global/content/bindings/dialog.xml
Line: 132
Error: dialog.getButton is not a function
Source File: chrome://global/content/commonDialog.js
Line: 109
Error: this._hitEnter is not a function
Source File: chrome://global/content/bindings/dialog.xml
Line: 394

With the new testcase the text does appear in the dialog and there are no errors
in the console, but the buttons are blank and non-functional.

Comment 21

[Robert Strong (they/them - no direct email)]

Every time I have seen this error in normal operations I also see those errors
in the js console that Dave commented on. If those errors don't show with a
testcase then that testcase may not be reproducing this specific bug.

Comment 22

[krazedout]

Perhaps this has something to do with 'Disable Common Annoyances' in the options
dialog under Javascript? If I recall correctly, I didn't encounter this bug
until I checked that option.

Comment 23

[Shayne Jewers]

just reproduced it with the set as default browser dialog with the following
warning in the JS console:

Install Location returned an item path that does not exist! Item Path:
C:\PROGRA~1\Firefox\extensions\{972ce4c6-7e08-4474-a285-3208198ce6fd}, Location
Key: app-global Item ID: {972ce4c6-7e08-4474-a285-3208198ce6fd}

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050716
Firefox/1.0+ ID:2005071606

Comment 24

[Steven]

Attachment: Empty "Software update" dialog box

I browsed a whole day with:   Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.8b4) Gecko/20050718 Firefox/1.0+ ID:${BuildID}

Then I checked for updates, and this was what's happend (I wanted to update to
the next nightly) 

This does happen sporadically. I've had it a few days ago too (but forget to
take a screenshot)

Comment 25

[Asa Dotzler [:asa]]

Ben, can you help us with this or triage to the right owner? This seems like
something we definitely need to fix. 

Those of you who can reproduce this, can you help us isolate the regression
window by testing nightly builds from archive.mozilla.org to narrow it down to
as small a window as possible? 

Comment 26

[Ben Goodger (use ben at mozilla dot org for email)]

I've been seeing this intermittently too since the last time I updated my tree
(updated yesterday, previous update about 5-7 days previous). For example:

<dialog .. >
 <label>Foo</label>
 <listbox id="bar" rows="5"/>
</dialog>

seemed to trigger it, but:

<dialog .. >
 <label>Foo</label>
</dialog>

.. not. 

Since dialog.xml seems not to have changed significantly in the time frame I
described above, I'm inclined to finger some change somewhere else... e.g. XBL,
DOM, etc. It seems that _configureButtons isn't installed on the binding when
the binding's ctor fires and calls it. Calling toSource on the documentElement
in the onload handler shows an empty object: {}

Comment 27

[Chris Beard]

mano or doron, could either of you take a look?

Comment 28

[Asaf Romano (gone)]

Is anyone still able to reproduce this? it is WFM for a pretty long time now (I
did see this issue).

Comment 29

[Dimitrios]

I saw it with 20050723. Now trying builds from archive.mozilla.org, per Asa's
suggestion...

Comment 30

[Dimitrios]

I think I found it (Devin's testcase in comment #19 was very helpful):
It was working in 2005-05-03-07 win32 trunk zipped build.
It stopped working in 2005-05-04-07 win32 trunk zipped build.

During that timeframe, there were quite a few js checkins and the enabling of
Reporter tool.

Comment 31

[Stebs]

Still can see this bug after several seconds of continiously keeping Enter
pressed on the less evil testcase with: Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8b4) Gecko/20050726 Firefox/1.0+ ID:2005072606
BUT ONLY with latest Adblock Plus 0.5.8+ (http://bene.sitesled.com/install.htm)
enabled! (+ Filterset.G used) (http://www.pierceive.com/)

When disabled (as Extension, not in Adblock self) or with a fresh and clean
Profile, this is WFM (pressed enter for 2-3 minutes)... 

Comment 32

[Asa Dotzler [:asa]]

I've cc'd some of the people who checked in during that window. If any of you
can look at the changes in this log to see if it might have busted dialog box
text in any way?

http://bonsai.mozilla.org/cvsquery.cgi?&module=MozillaTinderboxAll&branch=Head&filetype=notregexp&sortby=Date&hours=2&date=explicit&mindate=2005-05-03-07+08%3A00&maxdate=2005-05-04-07+08%3A00

Comment 33

[Boris Zbarsky [:bzbarsky]]

I don't really see any checkins in that range that would have these symptoms. 
The closest to it is bug 281988, and that's a stretch.

Comment 34

[Dimitrios]

After bz's comment, I felt the need to repeat the test with a new profile.
First, I ran 2005-05-03-07. Then I ran 2005-05-04-07. I didn't even need the
"less evil testcase": the prompt about entering an encrypted page was totally empty.

Comment 35

[Boris Zbarsky [:bzbarsky]]

Hmm... I can't seem to reproduce with the testcases.... :(

Comment 36

[Dave Townsend [:mossop]]

The testcases no longer work for me. But Im pretty sure I saw this in the last
few days.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729
Firefox/1.0+ ID:2005072906

Comment 37

[Peter van der Woude [:Peter6]]

If this still is a problem and we NEED to point at the bug who did it.
I have the following win32 zip builds to narrow it down:
for 20050503
-07:41 pdt
-09:38 pdt
-10:17 pdt
-12:47 pdt
-14:03 pdt
-15:25 pdt
-22:16 pdt
(times are time from serverstamp)

Comment 38

[Dimitrios]

It seems that Boris was right. I should have noticed that, with 20050504, some
buttons do have labels and that "less evil testcase" cannot be canceled.
Additionally, the problem I saw in 20050504 isn't affected by Adblock and it
went away with 20050506.

So I installed Adblock and started trying later builds. This time I hope I found
the real point where this bug started: 
1. it wfm with 2005051307
2. it doesn't work as expected with 2005051407
3. it wfm with 2005051407, if Adblock in uninstalled.

Comment 39

[Boris Zbarsky [:bzbarsky]]

So.. I tried installing adblock in a clean profile (so no adblock lists or
anything) and still can't reproduce with the testcase...

The one thing that changed in the range listed in comment 38 was a change to how
we do XBL load content policy checks, precisely needed for adblock....

Dimitrios, do you see the problem if adblock is installed but disabled?

Comment 40

[Stebs]

Has something changed concerning this bug since Nightly 20050726?
Tried to reproduce the bug like in my Comment #31, but was not able to.
New Profile + Adblock (without filterset): WFM + Filterset.G: WFM
New Profile + Adblock+ + Filterset.G: WFM
Old Profile + Adblock+ + Filterset.G: WFM

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050730
Firefox/1.0+ ID:2005073006 

Comment 41

[Boris Zbarsky [:bzbarsky]]

Possible, yes....

Comment 42

[Boris Zbarsky [:bzbarsky]]

Specifically, the checkin for bug 301316 might have fixed this.

Comment 43

[Stebs]

Ok, went ahead and downloaded Nightly 20050726 and tested less evil testcase
with my current Profile, always run into the bug in less than 10 seconds (mostly
took around 7).
Back to (now) Nightly 2005073110 (and same Profile naturally), stopped Testcase
after 2 minutes, it seems this is WFM for good now :)

Comment 44

[Caleb]

Marking WFM as per comments 42 and 43.

Comment 45

[:Gavin Sharp [email: [e-mail]]]

*** Bug 302010 has been marked as a duplicate of this bug. ***

Comment 46

[Dave Townsend [:mossop]]

*** Bug 307389 has been marked as a duplicate of this bug. ***