295902 - Document tab drag-and-droppability

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Jeff Walden (gone starting June 8)]

See the as-yet-unfixed bug 179656.  If that gets completed before 1.1, we should
have it documented by 1.1 as well.  The work will probably be adding some
keyboard shortcuts and mentioning draggability in tabbed_browsing.xhtml.

Comment 1

[Jeff Walden (gone starting June 8)]

Attachment: Patch - should need only minimal changes when bug 179656's fixed

If bug 179656 were to be fixed right now based on the last posted patch, this
would document it.  It's not ready, tho, so we wait.  I don't see us needing
any substantial changes to this patch, but there's always a chance.  Comments
are welcome as always, but there's no use scrutinizing this too much until the
functionality's frozen.

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 184824 [details] [diff] [review]
Patch - should need only minimal changes when bug 179656's fixed

The exact patch I used to document this has been checked into source, so this
is ready for review.

Note that I made no changes to firebird-toc.rdf.  The reason for this is that
the list of subheadings underneath Tabbed Browsing (and much of the
organization of the doc itself) is just screwy.  The first subheading
corresponds to an h2, others at the same level correspond to h3, etc.  This
needs to be fixed, sure, but I'd rather fix it in a separate followup bug (bug
296903).  For now I just want to get this documented and leave the extra,
less-essential polishing for later.

Comment 3

[Steffen Wilberg]

Comment on attachment 184824 [details] [diff] [review]
Patch - should need only minimal changes when bug 179656's fixed

Does Opera have this ability, and if so, does it have keyboard shortcuts for
that?

>Index: mozilla/browser/locales/en-US/chrome/help/tabbed_browsing.xhtml
>+  <p>Tabs are displayed in the order you open them, which may not always be
>+    what you want.  The initial ordering may make sense, but you might not
>+    always like having tabs in the exact order in which they were loaded.  To
The second sentence is superfluous. It's more or less the same as the first
sentence. I'd just remove it.

>+    move a tab to a different location within a &brandShortName; window, simply
>+    drag it there using your mouse.  While you are dragging the tab,
>+    &brandShortName; will display a small indicator to show where the tab will
Shouldn't this be "while you are dragging, Firefox *displays* a small
indicator"?

r=me with that sentence removed.

Comment 4

[Jeff Walden (gone starting June 8)]

Comment on attachment 184824 [details] [diff] [review]
Patch - should need only minimal changes when bug 179656's fixed

(In reply to comment #3)
> Does Opera have this ability, and if so, does it have keyboard shortcuts for
> that?

I asked on the Opera forums and was told that equivalent functionality isn't
keyboard-accessible (or at least it's not accessible with some special
shortcut).  What I've got in the patch now should be right.  (Incidentally, at
the same time I asked about our Opera shortcuts in general, so we'll probably
be updating those soon.  We've got a bug on it somewhere but I'm too lazy to
dig it out now.)

> >+    what you want.  The initial ordering may make sense, but you might not
> >+    always like having tabs in the exact order in which they were loaded.  To
> The second sentence is superfluous. It's more or less the same as the first
> sentence. I'd just remove it.

Point.	I don't remember why I had it there; maybe I just thought having only
one sentence of introduction at the beginning of the paragraph wasn't enough. 
Anyway, looking back I can't see any reason not to do this.

> >+    move a tab to a different location within a &brandShortName; window, simply
> >+    drag it there using your mouse.  While you are dragging the tab,
> >+    &brandShortName; will display a small indicator to show where the tab will
> Shouldn't this be "while you are dragging, Firefox *displays* a small
> indicator"?

"displays" makes sense to me.  I'm not as sure about removing "the tab", tho. 
Without it the phrase doesn't feel entirely coherent to me, even if context
makes it perfectly meaningful.	I think on checkin I'll go for "While you are
dragging the tab, Firefox displays a small[...]" (unless you have some
appropriately argued reason for removing "the tab").

Comment 5

[Steffen Wilberg]

> I think on checkin I'll go for "While you are
> dragging the tab, Firefox displays a small[...]" (unless you have some
> appropriately argued reason for removing "the tab").
That's exactly what I meant, just a s/will display/displays/. I didn't mean to
suggest to remove "the tab". I must have overlooked that.

Comment 6

[Jeff Walden (gone starting June 8)]

Patch checked in, with the requested changes.  Marking FIXED...