296559 - make calIDateTime.isDate = true set hours, minutes, seconds to 0

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stuart Parmenter]

make calIDateTime.isDate = true set hours, minutes, seconds to 0

Comment 1

[Stuart Parmenter]

Attachment: fix

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 185285 [details] [diff] [review]
fix

> NS_IMETHODIMP
>+calDateTime::SetIsDate(PRBool aIsDate)
>+{
>+    if (mImmutable)
>+        return NS_ERROR_FAILURE;
>+
>+    mIsDate = aIsDate;
>+    if (aIsDate) {
>+        mHour = 0;
>+        mMinute = 0;
>+        mSecond = 0;

Should Normalize here to make sure mNativeTime gets updated

>+    }
>+    return NS_OK;
>+}

with that, r=me

Comment 3

[Stuart Parmenter]

checked in